Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 319613004: Rename scheduleLayerUpdate now that it's only used for SVG filters. (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
Reviewers:
pdr., esprehn, f(malita)
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, rwlbuis, rune+blink, sof, zoltan1
Visibility:
Public.

Description

Rename scheduleLayerUpdate now that it's only used for SVG filters. This method is all sorts of badness. It leads to strange chicken-egg bugs because people don't think that you will need to update layer state after the layout has completed. FrameView::updateLayoutAndStyleIfNeededRecursive needs to do a second style recalc and layout just for this and in theory it should probably do a while loop there to get this right. Now that we've removed all the non-SVG filter callers of this function, rename it to something scary so that people won't add new callers. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175618

Patch Set 1 #

Patch Set 2 : rename all the things #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -36 lines) Patch
M Source/core/dom/Document.h View 1 3 chunks +6 lines, -7 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerFilterInfo.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ojan
This patch depends on https://codereview.chromium.org/318863002 and https://codereview.chromium.org/318773003.
6 years, 6 months ago (2014-06-05 02:51:02 UTC) #1
pdr.
On 2014/06/05 02:51:02, ojan wrote: > This patch depends on https://codereview.chromium.org/318863002 and > https://codereview.chromium.org/318773003. LGTM ...
6 years, 6 months ago (2014-06-05 03:33:10 UTC) #2
esprehn
lgtm
6 years, 6 months ago (2014-06-05 04:51:31 UTC) #3
f(malita)
lgtm
6 years, 6 months ago (2014-06-05 21:34:55 UTC) #4
ojan
> Could you add a bit more to the change description? Just flesh out why ...
6 years, 6 months ago (2014-06-05 21:40:05 UTC) #5
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-06-05 23:42:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/319613004/20001
6 years, 6 months ago (2014-06-05 23:43:07 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 01:32:08 UTC) #8
Message was sent while issue was closed.
Change committed as 175618

Powered by Google App Engine
This is Rietveld 408576698