Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 318863002: s/scheduleLayerUpdate/setNeedsCompositingUpdate in setRemoteWebLayer. (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
CC:
blink-reviews, kenrb
Visibility:
Public.

Description

s/scheduleLayerUpdate/setNeedsCompositingUpdate in setRemoteWebLayer. Now that frames always get a RenderLayer, we don't need to actually do a layer update anymore. Not sure how to test this. The original patch that added it https://codereview.chromium.org/104433003 didn't have any new tests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ojan
6 years, 6 months ago (2014-06-05 02:37:20 UTC) #1
esprehn
lgtm
6 years, 6 months ago (2014-06-05 05:30:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/318863002/1
6 years, 6 months ago (2014-06-05 05:31:54 UTC) #3
commit-bot: I haz the power
Change committed as 175542
6 years, 6 months ago (2014-06-05 06:56:03 UTC) #4
Ken Russell (switch to Gerrit)
Think you might have meant to CC kenrb.
6 years, 6 months ago (2014-06-05 18:05:41 UTC) #5
kenrb
6 years, 6 months ago (2014-06-05 18:21:27 UTC) #6
Message was sent while issue was closed.
This is fine. We are still working on a test framework for out-of-process
iframes, and for the Blink parts we do manual testing for now because there are
so few things that actually work as of yet.

Powered by Google App Engine
This is Rietveld 408576698