Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 318773003: s/scheduleLayerUpdate/setNeedsCompositingUpdate in setWebLayer. (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
Reviewers:
esprehn, alokp
CC:
blink-reviews
Visibility:
Public.

Description

s/scheduleLayerUpdate/setNeedsCompositingUpdate in setWebLayer. This was added in http://src.chromium.org/viewvc/blink?view=revision&revision=80584. It didn't have tests, so I'm not sure how to test this. But plugins always have a RenderLayer, so there should be no need to schedule a layer update anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
ojan
6 years, 6 months ago (2014-06-05 02:43:25 UTC) #1
alokp
lgtm
6 years, 6 months ago (2014-06-05 13:18:36 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-06-05 19:55:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/318773003/1
6 years, 6 months ago (2014-06-05 19:56:15 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-05 21:08:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 21:26:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/13547)
6 years, 6 months ago (2014-06-05 21:26:22 UTC) #7
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-06-05 21:36:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/318773003/1
6 years, 6 months ago (2014-06-05 21:37:00 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-05 21:58:23 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 22:20:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/13577)
6 years, 6 months ago (2014-06-05 22:20:10 UTC) #12
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-06-05 22:53:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/318773003/1
6 years, 6 months ago (2014-06-05 22:54:10 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 23:27:02 UTC) #15
Message was sent while issue was closed.
Change committed as 175597

Powered by Google App Engine
This is Rietveld 408576698