Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 319183004: Prefer to forward-declare GraphicsContext in headers. (Closed)

Created:
6 years, 6 months ago by jbroman
Modified:
6 years, 6 months ago
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, Rik, caseq+blink_chromium.org, danakj, devtools-reviews_chromium.org, dglazkov+blink, krit, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, f(malita), fs, gavinp+loader_chromium.org, gyuyoung.kim_webkit.org, jamesr, Nate Chapin, jbroman, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, rune+blink, Stephen Chennney, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org, zoltan1
Visibility:
Public.

Description

Prefer to forward-declare GraphicsContext in headers. Then clean up the errors that result from changing that. For me, this reduces the number of targets built on a trivial change to GraphicsContext.h from 888 to 297. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175919

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : mac #

Patch Set 4 : mac #

Total comments: 2

Patch Set 5 : schenney nit (pare down platform/geometry/ includes to *Rect.h) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -17 lines) Patch
M Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/Caret.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/fetch/ImageResource.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/fetch/Resource.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/ChromeClient.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/FilterEffectRenderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/InlineTextBox.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderScrollbar.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderScrollbarTheme.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/shapes/Shape.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGEllipse.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/BitmapImage.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEMorphology.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/mac/LocalCurrentGraphicsContext.h View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.mm View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarTheme.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarTheme.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.mm View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarThemeMock.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeOverlay.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/PageOverlay.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jbroman
Pretty minor, but I was getting annoyed at how many targets build whenever I change ...
6 years, 6 months ago (2014-06-10 13:42:04 UTC) #1
Stephen Chennney
LGTM, but you'll also need a web owner for a rubber stamp. https://codereview.chromium.org/319183004/diff/60001/Source/platform/mac/ScrollAnimatorMac.mm File Source/platform/mac/ScrollAnimatorMac.mm ...
6 years, 6 months ago (2014-06-10 15:52:04 UTC) #2
ojan
lgtm as well Please remove the BUG= line from the change description.
6 years, 6 months ago (2014-06-10 17:48:50 UTC) #3
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 6 months ago (2014-06-10 18:19:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/319183004/80001
6 years, 6 months ago (2014-06-10 18:20:26 UTC) #5
jbroman
https://codereview.chromium.org/319183004/diff/60001/Source/platform/mac/ScrollAnimatorMac.mm File Source/platform/mac/ScrollAnimatorMac.mm (right): https://codereview.chromium.org/319183004/diff/60001/Source/platform/mac/ScrollAnimatorMac.mm#newcode37 Source/platform/mac/ScrollAnimatorMac.mm:37: #include "platform/geometry/IntSize.h" On 2014/06/10 15:52:03, Stephen Chenney wrote: > ...
6 years, 6 months ago (2014-06-10 18:20:31 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-10 19:28:32 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 20:10:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/11000)
6 years, 6 months ago (2014-06-10 20:10:50 UTC) #9
Stephen Chennney
The CQ bit was checked by schenney@chromium.org
6 years, 6 months ago (2014-06-10 20:53:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/319183004/80001
6 years, 6 months ago (2014-06-10 20:54:04 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 21:44:49 UTC) #12
Message was sent while issue was closed. 
Change committed as 175919

Powered by Google App Engine
This is Rietveld 408576698