Issue 318373002: Revert 273044 "Change kEnableAudioTrackProcessing to a disable f..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 318373002: Revert 273044 "Change kEnableAudioTrackProcessing to a disable f..." (Closed)

Created:
6 years, 6 months ago by no longer working on chromium

Modified:
6 years, 6 months ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 273044 "Change kEnableAudioTrackProcessing to a disable f..." > Change kEnableAudioTrackProcessing to a disable flag and remove finch code for AudioTrackProcessing. > > The plan is to enable audio processing in getUserMedia as default for M37, and keep a kDisableAudioTrackProcessing flag to be able to fall back to the old path. > > BUG=365672 > TEST=bots > > Review URL: https://codereview.chromium.org/293023003 TBR=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275781

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -33 lines)			Patch
M	trunk/src/chrome/browser/chromeos/login/chrome_restart_request.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/browser/media/webrtc_browsertest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/browser/media/webrtc_getusermedia_browsertest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_process_host_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/public/common/content_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/public/common/content_switches.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	trunk/src/content/renderer/media/media_stream_audio_processor.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/renderer/media/media_stream_audio_processor.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	trunk/src/content/renderer/media/media_stream_audio_processor_unittest.cc	View	5 chunks	+15 lines, -3 lines	0 comments	Download
M	trunk/src/content/renderer/media/webrtc/peer_connection_dependency_factory.cc	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	trunk/src/content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	trunk/src/content/renderer/media/webrtc_audio_capturer_unittest.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	trunk/src/content/renderer/media/webrtc_local_audio_track.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

no longer working on chromium

6 years, 6 months ago (2014-06-09 08:10:32 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r275781 (tree was closed).

Expand Messages | Collapse Messages