Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 293023003: Change kEnableAudioTrackProcessing to a disable flag and remove finch code (Closed)

Created:
6 years, 7 months ago by no longer working on chromium
Modified:
6 years, 7 months ago
CC:
chromium-reviews, creis+watch_chromium.org, fischman+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Change kEnableAudioTrackProcessing to a disable flag and remove finch code for AudioTrackProcessing. The plan is to enable audio processing in getUserMedia as default for M37, and keep a kDisableAudioTrackProcessing flag to be able to fall back to the old path. BUG=365672 TEST=bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273044

Patch Set 1 : #

Total comments: 2

Patch Set 2 : remove one un-needed #include #

Patch Set 3 : fixed unittests #

Patch Set 4 : nits to fix more bots. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -50 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/webrtc_getusermedia_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_unittest.cc View 1 2 5 chunks +3 lines, -15 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc_audio_capturer_unittest.cc View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_track.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
no longer working on chromium
Hi Tommi, please review this CL. Jochen, owner stamp. Thanks, SX
6 years, 7 months ago (2014-05-20 15:00:35 UTC) #1
jochen (gone - plz use gerrit)
lgtm please update the referenced bug to a launch bug https://codereview.chromium.org/293023003/diff/20001/content/renderer/media/media_stream_audio_processor.cc File content/renderer/media/media_stream_audio_processor.cc (left): https://codereview.chromium.org/293023003/diff/20001/content/renderer/media/media_stream_audio_processor.cc#oldcode161 ...
6 years, 7 months ago (2014-05-21 08:53:13 UTC) #2
tommi (sloooow) - chröme
lgtm
6 years, 7 months ago (2014-05-22 06:35:51 UTC) #3
no longer working on chromium
Thanks, I have already updated the bug to be of launch type. Landing soon. https://codereview.chromium.org/293023003/diff/20001/content/renderer/media/media_stream_audio_processor.cc ...
6 years, 7 months ago (2014-05-26 10:02:15 UTC) #4
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 7 months ago (2014-05-26 10:02:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/293023003/40001
6 years, 7 months ago (2014-05-26 10:03:27 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 14:14:11 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 14:20:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/145792)
6 years, 7 months ago (2014-05-26 14:20:34 UTC) #9
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 7 months ago (2014-05-27 10:09:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/293023003/60001
6 years, 7 months ago (2014-05-27 10:09:16 UTC) #11
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 7 months ago (2014-05-27 12:57:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/293023003/100001
6 years, 7 months ago (2014-05-27 12:57:55 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 16:20:23 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 16:25:32 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77956)
6 years, 7 months ago (2014-05-27 16:25:33 UTC) #16
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 7 months ago (2014-05-27 20:18:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/293023003/100001
6 years, 7 months ago (2014-05-27 20:21:43 UTC) #18
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 21:52:20 UTC) #19
Message was sent while issue was closed.
Change committed as 273044

Powered by Google App Engine
This is Rietveld 408576698