Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: trunk/src/content/renderer/media/media_stream_audio_processor_unittest.cc

Issue 318373002: Revert 273044 "Change kEnableAudioTrackProcessing to a disable f..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/renderer/media/media_stream_audio_processor_unittest.cc
===================================================================
--- trunk/src/content/renderer/media/media_stream_audio_processor_unittest.cc (revision 275780)
+++ trunk/src/content/renderer/media/media_stream_audio_processor_unittest.cc (working copy)
@@ -154,9 +154,7 @@
};
TEST_F(MediaStreamAudioProcessorTest, WithoutAudioProcessing) {
- // Setup the audio processor with disabled flag on.
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kDisableAudioTrackProcessing);
+ // Setup the audio processor without enabling the flag.
MockMediaConstraintFactory constraint_factory;
scoped_refptr<WebRtcAudioDeviceImpl> webrtc_audio_device(
new WebRtcAudioDeviceImpl());
@@ -177,6 +175,9 @@
}
TEST_F(MediaStreamAudioProcessorTest, WithAudioProcessing) {
+ // Setup the audio processor with the flag enabled.
+ CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnableAudioTrackProcessing);
MockMediaConstraintFactory constraint_factory;
scoped_refptr<WebRtcAudioDeviceImpl> webrtc_audio_device(
new WebRtcAudioDeviceImpl());
@@ -198,6 +199,9 @@
}
TEST_F(MediaStreamAudioProcessorTest, VerifyTabCaptureWithoutAudioProcessing) {
+ // Setup the audio processor with enabling the flag.
+ CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnableAudioTrackProcessing);
scoped_refptr<WebRtcAudioDeviceImpl> webrtc_audio_device(
new WebRtcAudioDeviceImpl());
// Create MediaStreamAudioProcessor instance for kMediaStreamSourceTab source.
@@ -234,6 +238,10 @@
}
TEST_F(MediaStreamAudioProcessorTest, TurnOffDefaultConstraints) {
+ // Setup the audio processor with enabling the flag.
+ CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnableAudioTrackProcessing);
+
// Turn off the default constraints and pass it to MediaStreamAudioProcessor.
MockMediaConstraintFactory constraint_factory;
constraint_factory.DisableDefaultAudioConstraints();
@@ -256,6 +264,10 @@
}
TEST_F(MediaStreamAudioProcessorTest, VerifyConstraints) {
+ // Setup the audio processor with enabling the flag.
+ CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnableAudioTrackProcessing);
+
static const char* kDefaultAudioConstraints[] = {
MediaAudioConstraints::kEchoCancellation,
MediaAudioConstraints::kGoogAudioMirroring,

Powered by Google App Engine
This is Rietveld 408576698