Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: trunk/src/content/renderer/media/webrtc_audio_capturer_unittest.cc

Issue 318373002: Revert 273044 "Change kEnableAudioTrackProcessing to a disable f..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/renderer/media/webrtc_audio_capturer_unittest.cc
===================================================================
--- trunk/src/content/renderer/media/webrtc_audio_capturer_unittest.cc (revision 275780)
+++ trunk/src/content/renderer/media/webrtc_audio_capturer_unittest.cc (working copy)
@@ -84,9 +84,9 @@
#endif
}
- void DisableAudioTrackProcessing() {
+ void EnableAudioTrackProcessing() {
CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kDisableAudioTrackProcessing);
+ switches::kEnableAudioTrackProcessing);
}
void VerifyAudioParams(const blink::WebMediaConstraints& constraints,
@@ -156,14 +156,14 @@
// Pass the delay value, volume and key_pressed info via capture callback, and
// those values should be correctly stored and passed to the track.
-TEST_F(WebRtcAudioCapturerTest, VerifyAudioParamsWithoutAudioProcessing) {
- DisableAudioTrackProcessing();
+TEST_F(WebRtcAudioCapturerTest, VerifyAudioParams) {
// Use constraints with default settings.
MockMediaConstraintFactory constraint_factory;
VerifyAudioParams(constraint_factory.CreateWebMediaConstraints(), true);
}
TEST_F(WebRtcAudioCapturerTest, VerifyAudioParamsWithAudioProcessing) {
+ EnableAudioTrackProcessing();
// Turn off the default constraints to verify that the sink will get packets
// with a buffer size smaller than 10ms.
MockMediaConstraintFactory constraint_factory;
@@ -172,6 +172,7 @@
}
TEST_F(WebRtcAudioCapturerTest, FailToCreateCapturerWithWrongConstraints) {
+ EnableAudioTrackProcessing();
MockMediaConstraintFactory constraint_factory;
const std::string dummy_constraint = "dummy";
constraint_factory.AddMandatory(dummy_constraint, true);

Powered by Google App Engine
This is Rietveld 408576698