Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 315023006: Revert of Generalize and refactor DeviceSensorEvent* architecture to support multi-event type targets. (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org
Visibility:
Public.

Description

Revert of Generalize and refactor DeviceSensorEvent* architecture to support multi-event type targets. (https://codereview.chromium.org/315573002/) Reason for revert: Triggers assert in fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html Original issue's description: > Generalize and refactor DeviceSensorEvent* architecture to support > multi-event type targets. > > This patch performs a significant refactoring of the > DeviceSensorEvent{Controller,Dispatcher} and related classes. > It provides new Base classes to allow simple implementation of > APIs involving multi-event type non-window targets (e.g. Battery > Status API). Additionally it makes the implementation of existing > event-based APIs (device_orientation, device_light) simpler and > more compact. > > In particular the following new classes have been added: > * DeviceEventControllerBase and DeviceEventDispatcherBase > (derived from by the Battery Status API). > * DeviceSingleWindowEventController is more specific and > contains functionality necessary for single-event type window > target APIs (used by Device Motion/Orientation and Device Light > APIs). > > BUG=122593, 360068 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175661 TBR=ch.dumez@samsung.com,abarth@chromium.org,jochen@chromium.org,tkent@chromium.org,timvolodine@chromium.org NOTREECHECKS=true NOTRY=true BUG=122593, 360068 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -523 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
D Source/core/frame/DeviceEventControllerBase.h View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/core/frame/DeviceEventControllerBase.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
D Source/core/frame/DeviceEventDispatcherBase.h View 1 chunk +0 lines, -37 lines 0 comments Download
D Source/core/frame/DeviceEventDispatcherBase.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
D Source/core/frame/DeviceSingleWindowEventController.h View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/core/frame/DeviceSingleWindowEventController.cpp View 1 chunk +0 lines, -73 lines 0 comments Download
M Source/modules/battery/BatteryDispatcher.h View 2 chunks +7 lines, -5 lines 0 comments Download
M Source/modules/battery/BatteryDispatcher.cpp View 2 chunks +48 lines, -3 lines 0 comments Download
M Source/modules/battery/BatteryManager.h View 3 chunks +11 lines, -10 lines 0 comments Download
M Source/modules/battery/BatteryManager.cpp View 3 chunks +39 lines, -30 lines 0 comments Download
M Source/modules/device_light/DeviceLightController.h View 2 chunks +16 lines, -9 lines 0 comments Download
M Source/modules/device_light/DeviceLightController.cpp View 2 chunks +46 lines, -15 lines 0 comments Download
M Source/modules/device_light/DeviceLightDispatcher.h View 2 chunks +7 lines, -5 lines 0 comments Download
M Source/modules/device_light/DeviceLightDispatcher.cpp View 3 chunks +25 lines, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionController.h View 2 chunks +42 lines, -12 lines 0 comments Download
M Source/modules/device_orientation/DeviceMotionController.cpp View 3 chunks +71 lines, -15 lines 0 comments Download
M Source/modules/device_orientation/DeviceMotionDispatcher.h View 3 chunks +7 lines, -5 lines 0 comments Download
M Source/modules/device_orientation/DeviceMotionDispatcher.cpp View 3 chunks +24 lines, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationController.h View 2 chunks +41 lines, -18 lines 0 comments Download
M Source/modules/device_orientation/DeviceOrientationController.cpp View 6 chunks +74 lines, -22 lines 0 comments Download
M Source/modules/device_orientation/DeviceOrientationDispatcher.h View 3 chunks +7 lines, -5 lines 0 comments Download
M Source/modules/device_orientation/DeviceOrientationDispatcher.cpp View 3 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
dcheng
6 years, 6 months ago (2014-06-06 16:25:17 UTC) #1
Created Revert of Generalize and refactor DeviceSensorEvent* architecture to
support multi-event type targets.

Powered by Google App Engine
This is Rietveld 408576698