Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1474)

Unified Diff: Source/modules/device_orientation/DeviceOrientationDispatcher.cpp

Issue 315023006: Revert of Generalize and refactor DeviceSensorEvent* architecture to support multi-event type targets. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationDispatcher.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/device_orientation/DeviceOrientationDispatcher.cpp
diff --git a/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp b/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp
index 4c82b25aaa92041c0318862cf2a01268c79d3f62..ed73d039e8a2fe02e57b474002e88edfc65157d1 100644
--- a/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp
+++ b/Source/modules/device_orientation/DeviceOrientationDispatcher.cpp
@@ -34,6 +34,7 @@
#include "modules/device_orientation/DeviceOrientationController.h"
#include "modules/device_orientation/DeviceOrientationData.h"
#include "public/platform/Platform.h"
+#include "wtf/TemporaryChange.h"
namespace WebCore {
@@ -51,6 +52,16 @@
{
}
+void DeviceOrientationDispatcher::addDeviceOrientationController(DeviceOrientationController* controller)
+{
+ addController(controller);
+}
+
+void DeviceOrientationDispatcher::removeDeviceOrientationController(DeviceOrientationController* controller)
+{
+ removeController(controller);
+}
+
void DeviceOrientationDispatcher::startListening()
{
blink::Platform::current()->setDeviceOrientationListener(this);
@@ -65,7 +76,19 @@
void DeviceOrientationDispatcher::didChangeDeviceOrientation(const blink::WebDeviceOrientationData& motion)
{
m_lastDeviceOrientationData = DeviceOrientationData::create(motion);
- notifyControllers();
+
+ {
+ TemporaryChange<bool> changeIsDispatching(m_isDispatching, true);
+ // Don't fire controllers removed or added during event dispatch.
+ size_t size = m_controllers.size();
+ for (size_t i = 0; i < size; ++i) {
+ if (m_controllers[i])
+ static_cast<DeviceOrientationController*>(m_controllers[i])->didChangeDeviceOrientation(m_lastDeviceOrientationData.get());
+ }
+ }
+
+ if (m_needsPurge)
+ purgeControllers();
}
DeviceOrientationData* DeviceOrientationDispatcher::latestDeviceOrientationData()
« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationDispatcher.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698