Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: Source/modules/battery/BatteryManager.cpp

Issue 315023006: Revert of Generalize and refactor DeviceSensorEvent* architecture to support multi-event type targets. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/battery/BatteryManager.h ('k') | Source/modules/device_light/DeviceLightController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/battery/BatteryManager.cpp
diff --git a/Source/modules/battery/BatteryManager.cpp b/Source/modules/battery/BatteryManager.cpp
index c494b432027159c857931db701ae66f87c7a0083..81114c592e416236594bcd520b4053f5049592a2 100644
--- a/Source/modules/battery/BatteryManager.cpp
+++ b/Source/modules/battery/BatteryManager.cpp
@@ -8,6 +8,7 @@
#include "RuntimeEnabledFeatures.h"
#include "modules/battery/BatteryDispatcher.h"
#include "modules/battery/BatteryStatus.h"
+#include <limits>
namespace WebCore {
@@ -24,8 +25,7 @@
BatteryManager::BatteryManager(ExecutionContext* context)
: ActiveDOMObject(context)
- , DeviceEventControllerBase(toDocument(context)->page())
- , m_batteryStatus(BatteryStatus::create())
+ , DeviceSensorEventController(toDocument(context)->page())
{
m_hasEventListener = true;
startUpdating();
@@ -33,63 +33,72 @@
bool BatteryManager::charging()
{
- return m_batteryStatus->charging();
+ if (const BatteryStatus* lastData = BatteryDispatcher::instance().getLatestData())
+ return lastData->charging();
+
+ return true;
}
double BatteryManager::chargingTime()
{
- return m_batteryStatus->chargingTime();
+ if (const BatteryStatus* lastData = BatteryDispatcher::instance().getLatestData())
+ return lastData->chargingTime();
+
+ return 0;
}
double BatteryManager::dischargingTime()
{
- return m_batteryStatus->dischargingTime();
+ if (const BatteryStatus* lastData = BatteryDispatcher::instance().getLatestData())
+ return lastData->dischargingTime();
+
+ return std::numeric_limits<double>::infinity();
}
double BatteryManager::level()
{
- return m_batteryStatus->level();
+ if (const BatteryStatus* lastData = BatteryDispatcher::instance().getLatestData())
+ return lastData->level();
+
+ return 1;
}
-void BatteryManager::didUpdateData()
+void BatteryManager::didChangeBatteryStatus(PassRefPtrWillBeRawPtr<Event> event)
{
ASSERT(RuntimeEnabledFeatures::batteryStatusEnabled());
- RefPtr<BatteryStatus> oldStatus = m_batteryStatus;
- m_batteryStatus = BatteryDispatcher::instance().latestData();
-
- // BatteryDispatcher also holds a reference to m_batteryStatus.
- ASSERT(m_batteryStatus->refCount() == 2);
-
- Document* document = toDocument(executionContext());
- if (document->activeDOMObjectsAreSuspended() || document->activeDOMObjectsAreStopped())
- return;
-
- ASSERT(oldStatus);
-
- if (m_batteryStatus->charging() != oldStatus->charging())
- dispatchEvent(Event::create(EventTypeNames::chargingchange));
- if (m_batteryStatus->chargingTime() != oldStatus->chargingTime())
- dispatchEvent(Event::create(EventTypeNames::chargingtimechange));
- if (m_batteryStatus->dischargingTime() != oldStatus->dischargingTime())
- dispatchEvent(Event::create(EventTypeNames::dischargingtimechange));
- if (m_batteryStatus->level() != oldStatus->level())
- dispatchEvent(Event::create(EventTypeNames::levelchange));
+ dispatchEvent(event);
}
void BatteryManager::registerWithDispatcher()
{
- BatteryDispatcher::instance().addController(this);
+ BatteryDispatcher::instance().addClient(this);
}
void BatteryManager::unregisterWithDispatcher()
{
- BatteryDispatcher::instance().removeController(this);
+ BatteryDispatcher::instance().removeClient(this);
}
bool BatteryManager::hasLastData()
{
- return BatteryDispatcher::instance().latestData();
+ return false;
+}
+
+PassRefPtrWillBeRawPtr<Event> BatteryManager::getLastEvent()
+{
+ // Events are dispached via BatteryManager::didChangeBatteryStatus()
+ return nullptr;
+}
+
+bool BatteryManager::isNullEvent(Event*)
+{
+ return false;
+}
+
+Document* BatteryManager::document()
+{
+ return toDocument(executionContext());
}
void BatteryManager::suspend()
« no previous file with comments | « Source/modules/battery/BatteryManager.h ('k') | Source/modules/device_light/DeviceLightController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698