Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: Source/modules/battery/BatteryManager.cpp

Issue 315023006: Revert of Generalize and refactor DeviceSensorEvent* architecture to support multi-event type targets. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/battery/BatteryManager.h" 6 #include "modules/battery/BatteryManager.h"
7 7
8 #include "RuntimeEnabledFeatures.h" 8 #include "RuntimeEnabledFeatures.h"
9 #include "modules/battery/BatteryDispatcher.h" 9 #include "modules/battery/BatteryDispatcher.h"
10 #include "modules/battery/BatteryStatus.h" 10 #include "modules/battery/BatteryStatus.h"
11 #include <limits>
11 12
12 namespace WebCore { 13 namespace WebCore {
13 14
14 PassRefPtrWillBeRawPtr<BatteryManager> BatteryManager::create(ExecutionContext* context) 15 PassRefPtrWillBeRawPtr<BatteryManager> BatteryManager::create(ExecutionContext* context)
15 { 16 {
16 RefPtrWillBeRawPtr<BatteryManager> batteryManager(adoptRefWillBeRefCountedGa rbageCollected(new BatteryManager(context))); 17 RefPtrWillBeRawPtr<BatteryManager> batteryManager(adoptRefWillBeRefCountedGa rbageCollected(new BatteryManager(context)));
17 batteryManager->suspendIfNeeded(); 18 batteryManager->suspendIfNeeded();
18 return batteryManager.release(); 19 return batteryManager.release();
19 } 20 }
20 21
21 BatteryManager::~BatteryManager() 22 BatteryManager::~BatteryManager()
22 { 23 {
23 } 24 }
24 25
25 BatteryManager::BatteryManager(ExecutionContext* context) 26 BatteryManager::BatteryManager(ExecutionContext* context)
26 : ActiveDOMObject(context) 27 : ActiveDOMObject(context)
27 , DeviceEventControllerBase(toDocument(context)->page()) 28 , DeviceSensorEventController(toDocument(context)->page())
28 , m_batteryStatus(BatteryStatus::create())
29 { 29 {
30 m_hasEventListener = true; 30 m_hasEventListener = true;
31 startUpdating(); 31 startUpdating();
32 } 32 }
33 33
34 bool BatteryManager::charging() 34 bool BatteryManager::charging()
35 { 35 {
36 return m_batteryStatus->charging(); 36 if (const BatteryStatus* lastData = BatteryDispatcher::instance().getLatestD ata())
37 return lastData->charging();
38
39 return true;
37 } 40 }
38 41
39 double BatteryManager::chargingTime() 42 double BatteryManager::chargingTime()
40 { 43 {
41 return m_batteryStatus->chargingTime(); 44 if (const BatteryStatus* lastData = BatteryDispatcher::instance().getLatestD ata())
45 return lastData->chargingTime();
46
47 return 0;
42 } 48 }
43 49
44 double BatteryManager::dischargingTime() 50 double BatteryManager::dischargingTime()
45 { 51 {
46 return m_batteryStatus->dischargingTime(); 52 if (const BatteryStatus* lastData = BatteryDispatcher::instance().getLatestD ata())
53 return lastData->dischargingTime();
54
55 return std::numeric_limits<double>::infinity();
47 } 56 }
48 57
49 double BatteryManager::level() 58 double BatteryManager::level()
50 { 59 {
51 return m_batteryStatus->level(); 60 if (const BatteryStatus* lastData = BatteryDispatcher::instance().getLatestD ata())
61 return lastData->level();
62
63 return 1;
52 } 64 }
53 65
54 void BatteryManager::didUpdateData() 66 void BatteryManager::didChangeBatteryStatus(PassRefPtrWillBeRawPtr<Event> event)
55 { 67 {
56 ASSERT(RuntimeEnabledFeatures::batteryStatusEnabled()); 68 ASSERT(RuntimeEnabledFeatures::batteryStatusEnabled());
57 69
58 RefPtr<BatteryStatus> oldStatus = m_batteryStatus; 70 dispatchEvent(event);
59 m_batteryStatus = BatteryDispatcher::instance().latestData();
60
61 // BatteryDispatcher also holds a reference to m_batteryStatus.
62 ASSERT(m_batteryStatus->refCount() == 2);
63
64 Document* document = toDocument(executionContext());
65 if (document->activeDOMObjectsAreSuspended() || document->activeDOMObjectsAr eStopped())
66 return;
67
68 ASSERT(oldStatus);
69
70 if (m_batteryStatus->charging() != oldStatus->charging())
71 dispatchEvent(Event::create(EventTypeNames::chargingchange));
72 if (m_batteryStatus->chargingTime() != oldStatus->chargingTime())
73 dispatchEvent(Event::create(EventTypeNames::chargingtimechange));
74 if (m_batteryStatus->dischargingTime() != oldStatus->dischargingTime())
75 dispatchEvent(Event::create(EventTypeNames::dischargingtimechange));
76 if (m_batteryStatus->level() != oldStatus->level())
77 dispatchEvent(Event::create(EventTypeNames::levelchange));
78 } 71 }
79 72
80 void BatteryManager::registerWithDispatcher() 73 void BatteryManager::registerWithDispatcher()
81 { 74 {
82 BatteryDispatcher::instance().addController(this); 75 BatteryDispatcher::instance().addClient(this);
83 } 76 }
84 77
85 void BatteryManager::unregisterWithDispatcher() 78 void BatteryManager::unregisterWithDispatcher()
86 { 79 {
87 BatteryDispatcher::instance().removeController(this); 80 BatteryDispatcher::instance().removeClient(this);
88 } 81 }
89 82
90 bool BatteryManager::hasLastData() 83 bool BatteryManager::hasLastData()
91 { 84 {
92 return BatteryDispatcher::instance().latestData(); 85 return false;
86 }
87
88 PassRefPtrWillBeRawPtr<Event> BatteryManager::getLastEvent()
89 {
90 // Events are dispached via BatteryManager::didChangeBatteryStatus()
91 return nullptr;
92 }
93
94 bool BatteryManager::isNullEvent(Event*)
95 {
96 return false;
97 }
98
99 Document* BatteryManager::document()
100 {
101 return toDocument(executionContext());
93 } 102 }
94 103
95 void BatteryManager::suspend() 104 void BatteryManager::suspend()
96 { 105 {
97 m_hasEventListener = false; 106 m_hasEventListener = false;
98 stopUpdating(); 107 stopUpdating();
99 } 108 }
100 109
101 void BatteryManager::resume() 110 void BatteryManager::resume()
102 { 111 {
103 m_hasEventListener = true; 112 m_hasEventListener = true;
104 startUpdating(); 113 startUpdating();
105 } 114 }
106 115
107 void BatteryManager::stop() 116 void BatteryManager::stop()
108 { 117 {
109 m_hasEventListener = false; 118 m_hasEventListener = false;
110 stopUpdating(); 119 stopUpdating();
111 } 120 }
112 121
113 } // namespace WebCore 122 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/modules/battery/BatteryManager.h ('k') | Source/modules/device_light/DeviceLightController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698