Add an ASSERT about cross-world wrapper leakage into ScriptValue

Add an ASSERT about cross-world wrapper leakage into ScriptValue

- This CL adds an ASSERT to ScriptValue to verify that ScriptValue::v8Value() is used in the same world that created the ScriptValue.

- To insert the check, we need to get a current world in ScriptValue::v8Value(). For that goal, this CL makes sure that we're in some context when calling ScriptValue::v8Value().

BUG=341032
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175837

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175944

[haraken, 2014-06-09 10:48:39]

PTAL

[haraken, 2014-06-09 23:22:54]

abarth@: Looks like jochen and adamk are ooo. Would you take a look at this when
you have a cycle?

[abarth-chromium, 2014-06-10 00:03:14]

On 2014/06/09 at 23:22:54, haraken wrote:
> abarth@: Looks like jochen and adamk are ooo. Would you take a look at this
when you have a cycle?

LGTM, but I'm not really an expert on this code anymore.

[haraken, 2014-06-10 00:35:13]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-06-10 00:35:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/314953005/120001

[commit-bot: I haz the power, 2014-06-10 00:46:55]

Change committed as 175837

[dcheng, 2014-06-10 06:08:28]

A revert of this CL has been created in
https://codereview.chromium.org/326853002/ by dcheng@chromium.org.

The reason for reverting is: Causes many browser_tests to fail:
ActiveScriptControllerBrowserTest.*
ExtensionApiTest.ContentScript*
etc.

[haraken, 2014-06-11 03:58:10]

On 2014/06/10 06:08:28, dcheng wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/326853002/ by mailto:dcheng@chromium.org.
> 
> The reason for reverting is: Causes many browser_tests to fail:
> ActiveScriptControllerBrowserTest.*
> ExtensionApiTest.ContentScript*
> etc.

Added a missing HandleScope. Relanding...

[haraken, 2014-06-11 03:58:14]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-06-11 03:59:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/314953005/160001

[commit-bot: I haz the power, 2014-06-11 05:08:19]

Change committed as 175944

[pguyot, 2014-11-08 19:28:38]

pguyot@gmail.com changed reviewers:
+ pguyot@gmail.com

[pguyot, 2014-11-08 19:28:40]

There is a bug in this commit that added escaping around ScriptValue, yielding a
crash in executeScriptInIsolatedWorld if there is more than one script to
execute.

https://codereview.chromium.org/314953005/diff/160001/Source/bindings/v8/Scri...
File Source/bindings/v8/ScriptController.cpp (right):

https://codereview.chromium.org/314953005/diff/160001/Source/bindings/v8/Scri...
Source/bindings/v8/ScriptController.cpp:614:
results->append(handleScope.Escape(resultArray->Get(i)));
EscapableHandleScope::Escape is supposed to be called only once, while here it
is called once per script result, consequently yielding crashes if there is more
than one script.

[haraken, 2014-11-10 04:09:18]

On 2014/11/08 19:28:40, pguyot wrote:
> There is a bug in this commit that added escaping around ScriptValue, yielding
a
> crash in executeScriptInIsolatedWorld if there is more than one script to
> execute.
> 
>
https://codereview.chromium.org/314953005/diff/160001/Source/bindings/v8/Scri...
> File Source/bindings/v8/ScriptController.cpp (right):
> 
>
https://codereview.chromium.org/314953005/diff/160001/Source/bindings/v8/Scri...
> Source/bindings/v8/ScriptController.cpp:614:
> results->append(handleScope.Escape(resultArray->Get(i)));
> EscapableHandleScope::Escape is supposed to be called only once, while here it
> is called once per script result, consequently yielding crashes if there is
more
> than one script.

Uploaded a fix here: https://codereview.chromium.org/713743002/