Source/modules/serviceworkers/WaitUntilObserver.cpp - Issue 314953005: Add an ASSERT about cross-world wrapper leakage into ScriptValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/WaitUntilObserver.cpp

Issue 314953005: Add an ASSERT about cross-world wrapper leakage into ScriptValue (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/serviceworkers/WaitUntilObserver.cpp

diff --git a/Source/modules/serviceworkers/WaitUntilObserver.cpp b/Source/modules/serviceworkers/WaitUntilObserver.cpp

index 549f9f9e5a170ad809bf9e38eebd3c9f77de6355..67770666e830b8fc7b85687c6252709008b51bab 100644

--- a/Source/modules/serviceworkers/WaitUntilObserver.cpp

+++ b/Source/modules/serviceworkers/WaitUntilObserver.cpp

@@ -75,10 +75,10 @@ void WaitUntilObserver::didDispatchEvent()

decrementPendingActivity();

}

-void WaitUntilObserver::waitUntil(const ScriptValue& value)

+void WaitUntilObserver::waitUntil(ScriptState* scriptState, const ScriptValue& value)

{

incrementPendingActivity();

- ScriptPromise::cast(value).then(

+ ScriptPromise::cast(scriptState, value).then(

ThenFunction::create(this, ThenFunction::Fulfilled),

ThenFunction::create(this, ThenFunction::Rejected));

}