Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp - Issue 314953005: Add an ASSERT about cross-world wrapper leakage into ScriptValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

Issue 314953005: Add an ASSERT about cross-world wrapper leakage into ScriptValue (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

diff --git a/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp b/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

index 596d8c1cb78f5e971af32f20303f95092db3ac28..cdc97cb12422a90581f12170bdfb24d0abd7b3fc 100644

--- a/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

+++ b/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

@@ -64,9 +64,9 @@

namespace WebCore {

-Node* InjectedScriptHost::scriptValueAsNode(ScriptValue value)

+Node* InjectedScriptHost::scriptValueAsNode(ScriptState* scriptState, ScriptValue value)

{

- v8::HandleScope scope(value.isolate());

+ ScriptState::Scope scope(scriptState);

if (!value.isObject() || value.isNull())

return 0;

return V8Node::toNative(v8::Handle<v8::Object>::Cast(value.v8Value()));