Add an ASSERT about cross-world wrapper leakage into ScriptValue

Source/bindings/v8/ScriptPreprocessor.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 31 matching lines @@
 #include "wtf/TemporaryChange.h"
 
 namespace WebCore {
 
 ScriptPreprocessor::ScriptPreprocessor(const ScriptSourceCode& preprocessorSourceCode, LocalFrame* frame)
     : m_isPreprocessing(false)
 {
     RefPtr<DOMWrapperWorld> world = DOMWrapperWorld::ensureIsolatedWorld(ScriptPreprocessorIsolatedWorldId, DOMWrapperWorld::mainWorldExtensionGroup);
     m_scriptState = ScriptState::from(toV8Context(frame, *world));
 
+    v8::HandleScope handleScope(m_scriptState->isolate());
     ASSERT(frame);
     v8::TryCatch tryCatch;
     tryCatch.SetVerbose(true);
     Vector<ScriptSourceCode> sources;
     sources.append(preprocessorSourceCode);
-    Vector<ScriptValue> scriptResults;
+    Vector<v8::Local<v8::Value> > scriptResults;
     frame->script().executeScriptInIsolatedWorld(ScriptPreprocessorIsolatedWorldId, sources, DOMWrapperWorld::mainWorldExtensionGroup, &scriptResults);
 
     if (scriptResults.size() != 1) {
         frame->console().addMessage(JSMessageSource, ErrorMessageLevel, "ScriptPreprocessor internal error, one ScriptSourceCode must give exactly one result.");
         return;
     }
 
-    ScriptValue preprocessorFunction = scriptResults[0];
-    if (!preprocessorFunction.isFunction()) {
+    v8::Local<v8::Value> preprocessorFunction = scriptResults[0];
+    if (preprocessorFunction.IsEmpty() || !preprocessorFunction->IsFunction()) {
         frame->console().addMessage(JSMessageSource, ErrorMessageLevel, "The preprocessor must compile to a function.");
         return;
     }
-    m_preprocessorFunction.set(m_scriptState->isolate(), v8::Handle<v8::Function>::Cast(preprocessorFunction.v8Value()));
+    m_preprocessorFunction.set(m_scriptState->isolate(), v8::Handle<v8::Function>::Cast(preprocessorFunction));
 }
 
 String ScriptPreprocessor::preprocessSourceCode(const String& sourceCode, const String& sourceName)
 {
     if (!isValid())
         return sourceCode;
 
     return preprocessSourceCode(sourceCode, sourceName, v8::Undefined(m_scriptState->isolate()));
 }
 
@@ skipping 23 matching lines @@
     TemporaryChange<bool> isPreprocessing(m_isPreprocessing, true);
     v8::Handle<v8::Value> resultValue = V8ScriptRunner::callAsFunction(isolate, m_preprocessorFunction.newLocal(isolate), m_scriptState->context()->Global(), WTF_ARRAY_LENGTH(argv), argv);
 
     if (!resultValue.IsEmpty() && resultValue->IsString())
         return toCoreStringWithNullCheck(resultValue.As<v8::String>());
 
     return sourceCode;
 }
 
 } // namespace WebCore