Issue 314723002: Fixed lint errors caused by "runtime/references" rule and the rule itself is restored.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 314723002: Fixed lint errors caused by "runtime/references" rule and the rule itself is restored. (Closed)

Created:
6 years, 6 months ago by Igor Sheludko

Modified:
6 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed lint errors caused by "runtime/references" rule (Is this a non-const reference?) and the rule itself is restored. BUG=v8:3326 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21651

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -133 lines)			Patch
M	src/arm/lithium-arm.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm64/lithium-arm64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/d8-posix.cc	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/jsregexp.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/jsregexp.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/liveedit.cc	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	src/mips/assembler-mips.cc	View	1 chunk	+10 lines, -8 lines	0 comments	Download
M	src/mips/frames-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/lithium-codegen-mips.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	7 chunks	+22 lines, -22 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/simulator-mips.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/mips/simulator-mips.cc	View	9 chunks	+49 lines, -50 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/stub-cache.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/stub-cache.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x87/lithium-x87.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/presubmit.py	View	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r21651.

Expand Messages | Collapse Messages