tools/presubmit.py - Issue 314723002: Fixed lint errors caused by "runtime/references" rule and the rule itself is restored.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/presubmit.py

Issue 314723002: Fixed lint errors caused by "runtime/references" rule and the rule itself is restored. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/presubmit.py

diff --git a/tools/presubmit.py b/tools/presubmit.py

index a4ca39980522fbdbfe40527b90cd825520ceec62..029d5388466f72fd66e884eb24b59ab288b6d650 100755

--- a/tools/presubmit.py

+++ b/tools/presubmit.py

@@ -48,8 +48,6 @@ from subprocess import PIPE

# Disabled LINT rules and reason.

# build/include_what_you_use: Started giving false positives for variables

# named "string" and "map" assuming that you needed to include STL headers.

-# runtime/references: Started giving a lot of positives after depot-tools

-# update. To be fixed soon: v8:3326.

ENABLED_LINT_RULES = """

build/class

@@ -82,6 +80,7 @@ runtime/mutex

runtime/nonconf

runtime/printf

runtime/printf_format

+runtime/references

runtime/rtti

runtime/sizeof

runtime/string

« no previous file with comments | « test/cctest/test-api.cc ('k') | no next file » | no next file with comments »