Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Side by Side Diff: tools/presubmit.py

Issue 314723002: Fixed lint errors caused by "runtime/references" rule and the rule itself is restored. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-api.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2012 the V8 project authors. All rights reserved. 3 # Copyright 2012 the V8 project authors. All rights reserved.
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 30 matching lines...) Expand all
41 import pickle 41 import pickle
42 import re 42 import re
43 import sys 43 import sys
44 import subprocess 44 import subprocess
45 import multiprocessing 45 import multiprocessing
46 from subprocess import PIPE 46 from subprocess import PIPE
47 47
48 # Disabled LINT rules and reason. 48 # Disabled LINT rules and reason.
49 # build/include_what_you_use: Started giving false positives for variables 49 # build/include_what_you_use: Started giving false positives for variables
50 # named "string" and "map" assuming that you needed to include STL headers. 50 # named "string" and "map" assuming that you needed to include STL headers.
51 # runtime/references: Started giving a lot of positives after depot-tools
52 # update. To be fixed soon: v8:3326.
53 51
54 ENABLED_LINT_RULES = """ 52 ENABLED_LINT_RULES = """
55 build/class 53 build/class
56 build/deprecated 54 build/deprecated
57 build/endif_comment 55 build/endif_comment
58 build/forward_decl 56 build/forward_decl
59 build/include_order 57 build/include_order
60 build/printf_format 58 build/printf_format
61 build/storage_class 59 build/storage_class
62 legal/copyright 60 legal/copyright
(...skipping 12 matching lines...) Expand all
75 runtime/arrays 73 runtime/arrays
76 runtime/casting 74 runtime/casting
77 runtime/deprecated_fn 75 runtime/deprecated_fn
78 runtime/explicit 76 runtime/explicit
79 runtime/int 77 runtime/int
80 runtime/memset 78 runtime/memset
81 runtime/mutex 79 runtime/mutex
82 runtime/nonconf 80 runtime/nonconf
83 runtime/printf 81 runtime/printf
84 runtime/printf_format 82 runtime/printf_format
83 runtime/references
85 runtime/rtti 84 runtime/rtti
86 runtime/sizeof 85 runtime/sizeof
87 runtime/string 86 runtime/string
88 runtime/virtual 87 runtime/virtual
89 runtime/vlog 88 runtime/vlog
90 whitespace/blank_line 89 whitespace/blank_line
91 whitespace/braces 90 whitespace/braces
92 whitespace/comma 91 whitespace/comma
93 whitespace/comments 92 whitespace/comments
94 whitespace/ending_newline 93 whitespace/ending_newline
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 success = SourceProcessor().Run(workspace) and success 443 success = SourceProcessor().Run(workspace) and success
445 success = CheckGeneratedRuntimeTests(workspace) and success 444 success = CheckGeneratedRuntimeTests(workspace) and success
446 if success: 445 if success:
447 return 0 446 return 0
448 else: 447 else:
449 return 1 448 return 1
450 449
451 450
452 if __name__ == '__main__': 451 if __name__ == '__main__':
453 sys.exit(Main()) 452 sys.exit(Main())
OLDNEW
« no previous file with comments | « test/cctest/test-api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698