Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 313403005: Revert of Invert DSF to map from delegated frame to layer space (Closed)

Created:
6 years, 6 months ago by acleung1
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, danakj, piman, scottmg
Visibility:
Public.

Description

Revert of Invert DSF to map from delegated frame to layer space (https://codereview.chromium.org/311253004/) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=381982 Original issue's description: > Invert DSF to map from delegated frame to layer space > > The size of the frame data from a delegated source will not in general match up > exactly with the delegated layer's bounds. Frame sizes and layer bounds are both > expressed as integers, but frame sizes are in physical pixels and layer bounds > are in device-independent pixels. If the device scale is not an integer, there > may not be an exact mapping between the two spaces. For instance, if the layer > size is 105 x 211 and the device scale is 1.5, the delegated content is > responsible for filling 157.5 x 316.5 physical pixels in the final output. This > isn't really possible so what actually happens is the delegated renderer > produces a frame with a physical size of 158 x 317 pixels and sends that up to > the DRLI. To map this frame into physical space, the DRLI should apply the > inverse of the device scale factor to reflect that the frame covers 105.333 x > 211.3333 logical pixels. > > Before this patch, DRLI would attempt to scale the frame by (105/158, 211/317) > resulting in the frame being scaled down non-uniformly to try to make 158 x 317 > pixels fit into a 157.5 x 316.6 space. This scaling looks bad and ends up > mapping pixels partially outside of the layer's logical bounds into the layer's > logical bounds. > > BUG=370074 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275544 TBR=enne@chromium.org,danakj@chromium.org,jamesr@chromium.org,jam@chromium.org NOTREECHECKS=true NOTRY=true BUG=370074, 381982 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -108 lines) Patch
M cc/layers/delegated_renderer_layer_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 5 chunks +20 lines, -12 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl_unittest.cc View 17 chunks +57 lines, -68 lines 0 comments Download
M cc/output/delegated_frame_data.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/output/delegated_frame_data.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/delegating_renderer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/fake_delegated_renderer_layer_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/fake_delegated_renderer_layer_impl.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_delegated.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M content/common/cc_messages.cc View 3 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
acleung1
Created Revert of Invert DSF to map from delegated frame to layer space
6 years, 6 months ago (2014-06-07 03:20:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acleung@chromium.org/313403005/1
6 years, 6 months ago (2014-06-07 03:21:13 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-07 03:21:13 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-07 03:21:14 UTC) #4
dcheng
LGTM
6 years, 6 months ago (2014-06-07 03:24:15 UTC) #5
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 6 months ago (2014-06-07 03:26:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acleung@chromium.org/313403005/1
6 years, 6 months ago (2014-06-07 03:29:16 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 03:32:02 UTC) #8
Message was sent while issue was closed.
Change committed as 275600

Powered by Google App Engine
This is Rietveld 408576698