Add IPC::ChannelProxy::Create() and IPC::SyncChannel::Create()

Add IPC::ChannelProxy::Create() and IPC::SyncChannel::Create()

This change replaces constructors with Create() methods of
ChannelProxy and SyncChannel. This open the possibility to introduce
polymorphism to these classes.

This is a revision of r274310 (https://codereview.chromium.org/301973003/)
in which I added bunch of Create*() method variants.
The chagne was reverted. This change no longer does it and just keeps
using Channel::Mode to specify the channel type.

TEST=none
BUG=377980
R=darin@chromium.org,jam@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275140

[jam, 2014-06-03 17:30:40]

https://codereview.chromium.org/310853003/diff/1/content/child/npapi/np_chann...
File content/child/npapi/np_channel_base.cc (right):

https://codereview.chromium.org/310853003/diff/1/content/child/npapi/np_chann...
content/child/npapi/np_channel_base.cc:181: channel_ =
IPC::SyncChannel::Create(this, ipc_message_loop, shutdown_event);
why not use the Create method with 6 parameters as before? splitting
construction from Init call before is only done when needing to add filters
in-between

https://codereview.chromium.org/310853003/diff/1/ipc/ipc_channel_proxy.h
File ipc/ipc_channel_proxy.h (right):

https://codereview.chromium.org/310853003/diff/1/ipc/ipc_channel_proxy.h#newc...
ipc/ipc_channel_proxy.h:73: // This Create() does not create underlying channel
and let Init() do it.
i dont think this is needed if the other code where i commented stays the same
as before

https://codereview.chromium.org/310853003/diff/1/ppapi/proxy/proxy_channel.cc
File ppapi/proxy/proxy_channel.cc (right):

https://codereview.chromium.org/310853003/diff/1/ppapi/proxy/proxy_channel.cc...
ppapi/proxy/proxy_channel.cc:39: true);
ditto

[jam, 2014-06-03 17:30:40]

https://codereview.chromium.org/310853003/diff/1/content/child/npapi/np_chann...
File content/child/npapi/np_channel_base.cc (right):

https://codereview.chromium.org/310853003/diff/1/content/child/npapi/np_chann...
content/child/npapi/np_channel_base.cc:181: channel_ =
IPC::SyncChannel::Create(this, ipc_message_loop, shutdown_event);
why not use the Create method with 6 parameters as before? splitting
construction from Init call before is only done when needing to add filters
in-between

https://codereview.chromium.org/310853003/diff/1/ipc/ipc_channel_proxy.h
File ipc/ipc_channel_proxy.h (right):

https://codereview.chromium.org/310853003/diff/1/ipc/ipc_channel_proxy.h#newc...
ipc/ipc_channel_proxy.h:73: // This Create() does not create underlying channel
and let Init() do it.
i dont think this is needed if the other code where i commented stays the same
as before

https://codereview.chromium.org/310853003/diff/1/ppapi/proxy/proxy_channel.cc
File ppapi/proxy/proxy_channel.cc (right):

https://codereview.chromium.org/310853003/diff/1/ppapi/proxy/proxy_channel.cc...
ppapi/proxy/proxy_channel.cc:39: true);
ditto

[Hajime Morrita, 2014-06-03 18:01:58]

PTAL?

https://codereview.chromium.org/310853003/diff/1/content/child/npapi/np_chann...
File content/child/npapi/np_channel_base.cc (right):

https://codereview.chromium.org/310853003/diff/1/content/child/npapi/np_chann...
content/child/npapi/np_channel_base.cc:181: channel_ =
IPC::SyncChannel::Create(this, ipc_message_loop, shutdown_event);
On 2014/06/03 17:30:41, jam wrote:
> why not use the Create method with 6 parameters as before? splitting
> construction from Init call before is only done when needing to add filters
> in-between

Done.

https://codereview.chromium.org/310853003/diff/1/ipc/ipc_channel_proxy.h
File ipc/ipc_channel_proxy.h (right):

https://codereview.chromium.org/310853003/diff/1/ipc/ipc_channel_proxy.h#newc...
ipc/ipc_channel_proxy.h:73: // This Create() does not create underlying channel
and let Init() do it.
On 2014/06/03 17:30:41, jam wrote:
> i dont think this is needed if the other code where i commented stays the same
> as before

Unfortunately we cannot remove this as ppapi_dispatcher.cc is using it.
That's why SyncChannel had two separate constructors.

https://codereview.chromium.org/310853003/diff/1/ppapi/proxy/proxy_channel.cc
File ppapi/proxy/proxy_channel.cc (right):

https://codereview.chromium.org/310853003/diff/1/ppapi/proxy/proxy_channel.cc...
ppapi/proxy/proxy_channel.cc:39: true);
On 2014/06/03 17:30:41, jam wrote:
> ditto

Done.

[jam, 2014-06-03 20:37:31]

https://codereview.chromium.org/310853003/diff/1/ipc/ipc_channel_proxy.h
File ipc/ipc_channel_proxy.h (right):

https://codereview.chromium.org/310853003/diff/1/ipc/ipc_channel_proxy.h#newc...
ipc/ipc_channel_proxy.h:73: // This Create() does not create underlying channel
and let Init() do it.
On 2014/06/03 18:01:59, morrita wrote:
> On 2014/06/03 17:30:41, jam wrote:
> > i dont think this is needed if the other code where i commented stays the
same
> > as before
> 
> Unfortunately we cannot remove this as ppapi_dispatcher.cc is using it.
> That's why SyncChannel had two separate constructors.

ah you're right, what about the ChannelProxy::Create though? SyncChannel is
using the constructor and not the second new create method you added there?

[gmorrita, 2014-06-03 20:50:54]

On 2014/06/03 20:37:31, jam wrote:
> ah you're right, what about the ChannelProxy::Create though? SyncChannel is
> using the constructor and not the second new create method you added there?

Oh good catch! We don't need it.
Please take yet another look? I just uploaded the revised change, removing
redundant ChannelProxy::Create().

[jam, 2014-06-03 21:49:15]

lgtm

[Hajime Morrita, 2014-06-03 22:00:19]

Thank you!
Darin: Could you rubberstamp this?

[darin (slow to review), 2014-06-03 22:44:50]

LGTM

[Hajime Morrita, 2014-06-03 22:45:27]

The CQ bit was checked by morrita@chromium.org

[Hajime Morrita, 2014-06-03 22:46:16]

Thank you!

[commit-bot: I haz the power, 2014-06-03 22:46:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/310853003/50001

[commit-bot: I haz the power, 2014-06-04 03:51:42]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-04 05:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-04 05:49:59]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[Hajime Morrita, 2014-06-04 20:11:43]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-06-04 20:13:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/310853003/70001

[commit-bot: I haz the power, 2014-06-05 00:23:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-06-05 00:37:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 00:37:24]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[Hajime Morrita, 2014-06-05 15:39:28]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-06-05 15:41:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/310853003/70001

[commit-bot: I haz the power, 2014-06-05 16:15:41]

Change committed as 275140