Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2246)

Unified Diff: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

Issue 310853003: Add IPC::ChannelProxy::Create() and IPC::SyncChannel::Create() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Landing Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/app_shim/chrome_main_app_mode_mac.mm ('k') | chrome/browser/service_process/service_process_control.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
diff --git a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
index cce36d643d0930e381edbf9b9601540d5cc37b5b..5f1c55e7c9dd49c1a58df9deefe29f2c63f031d8 100644
--- a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
+++ b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
@@ -266,11 +266,11 @@ int CloudPrintMockService_Main(SetExpectationsCallback set_expectations) {
CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
switches::kProcessChannelID);
scoped_ptr<IPC::ChannelProxy> startup_channel;
- startup_channel.reset(
- new IPC::ChannelProxy(startup_channel_name,
- IPC::Channel::MODE_CLIENT,
- &listener,
- service_process.IOMessageLoopProxy()));
+ startup_channel =
+ IPC::ChannelProxy::Create(startup_channel_name,
+ IPC::Channel::MODE_CLIENT,
+ &listener,
+ service_process.IOMessageLoopProxy());
main_message_loop.Run();
if (!Mock::VerifyAndClearExpectations(&server))
@@ -442,9 +442,10 @@ base::ProcessHandle CloudPrintProxyPolicyStartupTest::Launch(
base::StringPrintf("%d.%p.%d",
base::GetCurrentProcId(), this,
base::RandInt(0, std::numeric_limits<int>::max()));
- startup_channel_.reset(new IPC::ChannelProxy(
- startup_channel_id_, IPC::Channel::MODE_SERVER,
- this, IOMessageLoopProxy()));
+ startup_channel_ = IPC::ChannelProxy::Create(startup_channel_id_,
+ IPC::Channel::MODE_SERVER,
+ this,
+ IOMessageLoopProxy());
#if defined(OS_POSIX)
base::FileHandleMappingVector ipc_file_list;
@@ -466,10 +467,10 @@ void CloudPrintProxyPolicyStartupTest::WaitForConnect() {
EXPECT_TRUE(CheckServiceProcessReady());
EXPECT_TRUE(base::MessageLoopProxy::current().get());
ServiceProcessControl::GetInstance()->SetChannel(
- new IPC::ChannelProxy(GetServiceProcessChannel(),
- IPC::Channel::MODE_NAMED_CLIENT,
- ServiceProcessControl::GetInstance(),
- IOMessageLoopProxy()));
+ IPC::ChannelProxy::Create(GetServiceProcessChannel(),
+ IPC::Channel::MODE_NAMED_CLIENT,
+ ServiceProcessControl::GetInstance(),
+ IOMessageLoopProxy()));
}
bool CloudPrintProxyPolicyStartupTest::Send(IPC::Message* message) {
« no previous file with comments | « apps/app_shim/chrome_main_app_mode_mac.mm ('k') | chrome/browser/service_process/service_process_control.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698