content/child/npapi/np_channel_base.cc - Issue 310853003: Add IPC::ChannelProxy::Create() and IPC::SyncChannel::Create()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/npapi/np_channel_base.cc

Issue 310853003: Add IPC::ChannelProxy::Create() and IPC::SyncChannel::Create() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Landing Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/npapi/np_channel_base.cc

diff --git a/content/child/npapi/np_channel_base.cc b/content/child/npapi/np_channel_base.cc

index 76845bd8f21a9707079d201782c4ea9414747157..e7f2ca26bd2592c0f6c34753bbc779ff0a9d8f08 100644

--- a/content/child/npapi/np_channel_base.cc

+++ b/content/child/npapi/np_channel_base.cc

@@ -178,9 +178,9 @@ bool NPChannelBase::Init(base::MessageLoopProxy* ipc_message_loop,

return false;

#endif

- channel_.reset(new IPC::SyncChannel(

+ channel_ = IPC::SyncChannel::Create(

channel_handle_, mode_, this, ipc_message_loop, create_pipe_now,

- shutdown_event));

+ shutdown_event);

#if defined(OS_POSIX)

// Check the validity of fd for bug investigation. Remove after fixed.

« no previous file with comments | « content/child/child_thread.cc ('k') | content/common/gpu/client/gpu_channel_host.cc » ('j') | no next file with comments »