Add IPC::ChannelProxy::Create() and IPC::SyncChannel::Create()

content/child/npapi/np_channel_base.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/npapi/np_channel_base.h"
 
 #include "base/auto_reset.h"
 #include "base/containers/hash_tables.h"
 #include "base/files/scoped_file.h"
 #include "base/lazy_instance.h"
@@ skipping 160 matching lines @@
 bool NPChannelBase::Init(base::MessageLoopProxy* ipc_message_loop,
                          bool create_pipe_now,
                          base::WaitableEvent* shutdown_event) {
 #if defined(OS_POSIX)
   // Attempting to initialize with an invalid channel handle.
   // See http://crbug.com/97285 for details.
   if (mode_ == IPC::Channel::MODE_CLIENT && -1 == channel_handle_.socket.fd)
     return false;
 #endif
 
-  channel_.reset(new IPC::SyncChannel(
-      channel_handle_, mode_, this, ipc_message_loop, create_pipe_now,
-      shutdown_event));
+  channel_ = IPC::SyncChannel::Create(this, ipc_message_loop, shutdown_event);

[jam, 2014/06/03 17:30:41]

why not use the Create method with 6 parameters as before? splitting
construction from Init call before is only done when needing to add filters
in-between

[Hajime Morrita, 2014/06/03 18:01:59]

Done.

+  channel_->Init(channel_handle_, mode_, create_pipe_now);
 
 #if defined(OS_POSIX)
   // Check the validity of fd for bug investigation.  Remove after fixed.
   // See crbug.com/97285 for details.
   if (mode_ == IPC::Channel::MODE_SERVER)
     CHECK_NE(-1, channel_->GetClientFileDescriptor());
 #endif
 
   channel_valid_ = true;
   return true;
@@ skipping 183 matching lines @@
   RouteToOwnerMap::iterator iter = route_to_owner_.find(route_id);
   return iter != route_to_owner_.end() ? iter->second : default_owner_;
 }
 
 int NPChannelBase::GetExistingRouteForNPObjectOwner(NPP owner) {
   OwnerToRouteMap::iterator iter = owner_to_route_.find(owner);
   return iter != owner_to_route_.end() ? iter->second : MSG_ROUTING_NONE;
 }
 
 }  // namespace content