Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4722)

Unified Diff: chrome/browser/metrics/metrics_services_manager.h

Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_services_manager.h
diff --git a/chrome/browser/metrics/metrics_services_manager.h b/chrome/browser/metrics/metrics_services_manager.h
index 6e16b162bca16cb5cddce4580eb04d973c7892cc..a70c557ba68a93243fe94bea84de580cfba3d2ba 100644
--- a/chrome/browser/metrics/metrics_services_manager.h
+++ b/chrome/browser/metrics/metrics_services_manager.h
@@ -13,6 +13,10 @@ class ChromeMetricsServiceClient;
class MetricsService;
class PrefService;
+namespace base {
+class FilePath;
+}
+
namespace metrics {
class MetricsStateManager;
}
@@ -43,6 +47,9 @@ class MetricsServicesManager {
// Returns the VariationsService, creating it if it hasn't been created yet.
chrome_variations::VariationsService* GetVariationsService();
+ // Logs a plugin loading error.
+ void LogPluginLoadingError(const base::FilePath& plugin_path);
Alexei Svitkine (slow) 2014/05/30 15:21:35 Nit: I'd name this OnPluginLoadingError(). The fac
blundell 2014/06/01 14:02:17 Done.
+
private:
metrics::MetricsStateManager* GetMetricsStateManager();

Powered by Google App Engine
This is Rietveld 408576698