Reduce plugin_metrics_provider_ usage in MetricsService

chrome/browser/metrics/metrics_services_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_METRICS_METRICS_SERVICES_MANAGER_H_
 #define CHROME_BROWSER_METRICS_METRICS_SERVICES_MANAGER_H_
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/threading/thread_checker.h"
 
 class ChromeMetricsServiceClient;
 class MetricsService;
 class PrefService;
 
+namespace base {
+class FilePath;
+}
+
 namespace metrics {
 class MetricsStateManager;
 }
 
 namespace rappor {
 class RapporService;
 }
 
 namespace chrome_variations {
 class VariationsService;
@@ skipping 10 matching lines @@
 
   // Returns the MetricsService, creating it if it hasn't been created yet.
   MetricsService* GetMetricsService();
 
   // Returns the GetRapporService, creating it if it hasn't been created yet.
   rappor::RapporService* GetRapporService();
 
   // Returns the VariationsService, creating it if it hasn't been created yet.
   chrome_variations::VariationsService* GetVariationsService();
 
+  // Logs a plugin loading error.
+  void LogPluginLoadingError(const base::FilePath& plugin_path);

[Alexei Svitkine (slow), 2014/05/30 15:21:35]

Nit: I'd name this OnPluginLoadingError(). The fact that it gets logged is an
implementation detail of the metrics system (i.e. we can still keep this name in
the other classes).

[blundell, 2014/06/01 14:02:17]

Done.

+
  private:
   metrics::MetricsStateManager* GetMetricsStateManager();
 
   // Returns true iff metrics reporting is enabled.
   bool IsMetricsReportingEnabled() const;
 
   // Ensures that all functions are called from the same thread.
   base::ThreadChecker thread_checker_;
 
   // Weak pointer to the local state prefs store.
   PrefService* local_state_;
 
   // MetricsStateManager which is passed as a parameter to service constructors.
   scoped_ptr<metrics::MetricsStateManager> metrics_state_manager_;
 
   // Chrome embedder implementation of the MetricsServiceClient. Owns the
   // MetricsService.
   scoped_ptr<ChromeMetricsServiceClient> metrics_service_client_;
 
   // The RapporService, for RAPPOR metric uploads.
   scoped_ptr<rappor::RapporService> rappor_service_;
 
   // The VariationsService, for server-side experiments infrastructure.
   scoped_ptr<chrome_variations::VariationsService> variations_service_;
 
   DISALLOW_COPY_AND_ASSIGN(MetricsServicesManager);
 };
 
 #endif  // CHROME_BROWSER_METRICS_METRICS_SERVICES_MANAGER_H_