chrome/browser/metrics/metrics_service.cc - Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/metrics_service.h ('k') | chrome/browser/metrics/metrics_services_manager.h » ('j') | chrome/browser/metrics/metrics_services_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_service.cc

diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc

index d787dbd269a626fa694a0cf508ec364fe4368953..e13e92533d3ee9cb955ffad58a6dd7fefa9028ed 100644

--- a/chrome/browser/metrics/metrics_service.cc

+++ b/chrome/browser/metrics/metrics_service.cc

@@ -1392,7 +1392,6 @@ void MetricsService::LogCleanShutdown() {

void MetricsService::LogPluginLoadingError(const base::FilePath& plugin_path) {

#if defined(ENABLE_PLUGINS)

- // TODO(asvitkine): Move this out of here.

plugin_metrics_provider_->LogPluginLoadingError(plugin_path);

#endif

}

@@ -1413,7 +1412,6 @@ void MetricsService::RecordBooleanPrefValue(const char* path, bool value) {

void MetricsService::RecordCurrentState(PrefService* pref) {

pref->SetInt64(prefs::kStabilityLastTimestampSec, Time::Now().ToTimeT());

-#if defined(ENABLE_PLUGINS)

- plugin_metrics_provider_->RecordPluginChanges();

-#endif

+ for (size_t i = 0; i < metrics_providers_.size(); ++i)

+ metrics_providers_[i]->RecordCurrentState();

}