chrome/browser/metrics/metrics_services_manager.cc - Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_services_manager.cc

Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_services_manager.h ('K') | « chrome/browser/metrics/metrics_services_manager.h ('k') | chrome/browser/metrics/plugin_metrics_provider.h » ('j') | components/metrics/metrics_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_services_manager.cc

diff --git a/chrome/browser/metrics/metrics_services_manager.cc b/chrome/browser/metrics/metrics_services_manager.cc

index c560dcd714083cad9de5efe149daba1f4b613fd7..c1026d86172faaa23c3e00e195e249ce52f29ec2 100644

--- a/chrome/browser/metrics/metrics_services_manager.cc

+++ b/chrome/browser/metrics/metrics_services_manager.cc

@@ -58,6 +58,11 @@ MetricsServicesManager::GetVariationsService() {

return variations_service_.get();

}

+void MetricsServicesManager::LogPluginLoadingError(

+ const base::FilePath& plugin_path) {

+ GetMetricsService()->LogPluginLoadingError(plugin_path);

metrics::MetricsStateManager* MetricsServicesManager::GetMetricsStateManager() {

DCHECK(thread_checker_.CalledOnValidThread());

if (!metrics_state_manager_) {