Issue 308363002: Remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream: always

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308363002: Remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream: always (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)

Modified:
6 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream: always try sending a WINDOW_UPDATE from inside AddBytesConsumed. Whenever bytes_consumed changes we may want to send a WINDOW_UPDATE, and this CL prevents future users calling AddBytesConsumed and forgetting MaybeSendWindowUpdate. QUIC: remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream Merge internal change: 68188106 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -17 lines)			Patch
M	net/quic/quic_stream_sequencer.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	net/quic/reliable_quic_stream.h	View	1 chunk	+6 lines, -9 lines	0 comments	Download
M	net/quic/reliable_quic_stream.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages