Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: net/quic/reliable_quic_stream.cc

Issue 308363002: Remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream: always (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/reliable_quic_stream.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/reliable_quic_stream.cc
diff --git a/net/quic/reliable_quic_stream.cc b/net/quic/reliable_quic_stream.cc
index aefdb4126be6e4bd19b1344a6f0505229a75b7c5..e1068905961950dfb60a3481018b21c6878e896e 100644
--- a/net/quic/reliable_quic_stream.cc
+++ b/net/quic/reliable_quic_stream.cc
@@ -160,16 +160,10 @@ bool ReliableQuicStream::OnStreamFrame(const QuicStreamFrame& frame) {
session_->connection()->SendConnectionClose(QUIC_FLOW_CONTROL_ERROR);
return false;
}
- MaybeSendWindowUpdate();
return accepted;
}
-void ReliableQuicStream::MaybeSendWindowUpdate() {
- flow_controller_.MaybeSendWindowUpdate(session()->connection());
- connection_flow_controller_->MaybeSendWindowUpdate(session()->connection());
-}
-
int ReliableQuicStream::num_frames_received() const {
return sequencer_.num_frames_received();
}
@@ -460,7 +454,10 @@ void ReliableQuicStream::AddBytesSent(uint64 bytes) {
void ReliableQuicStream::AddBytesConsumed(uint64 bytes) {
if (flow_controller_.IsEnabled()) {
flow_controller_.AddBytesConsumed(bytes);
+ flow_controller_.MaybeSendWindowUpdate(session()->connection());
+
connection_flow_controller_->AddBytesConsumed(bytes);
+ connection_flow_controller_->MaybeSendWindowUpdate(session()->connection());
}
}
« no previous file with comments | « net/quic/reliable_quic_stream.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698