Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: net/quic/reliable_quic_stream.h

Issue 308363002: Remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream: always (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_sequencer.cc ('k') | net/quic/reliable_quic_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/reliable_quic_stream.h
diff --git a/net/quic/reliable_quic_stream.h b/net/quic/reliable_quic_stream.h
index 90cdac44551af58b9ed553c2d4b43b34cdbb94fe..7016d81960fa31a9e6178a3762c94b097072fd47 100644
--- a/net/quic/reliable_quic_stream.h
+++ b/net/quic/reliable_quic_stream.h
@@ -92,24 +92,21 @@ class NET_EXPORT_PRIVATE ReliableQuicStream {
// Adjust our flow control windows according to new offset in |frame|.
virtual void OnWindowUpdateFrame(const QuicWindowUpdateFrame& frame);
- // If our receive window has dropped below the threshold, then send a
- // WINDOW_UPDATE frame. This is called whenever bytes are consumed from the
- // sequencer's buffer.
- void MaybeSendWindowUpdate();
-
int num_frames_received() const;
int num_duplicate_frames_received() const;
QuicFlowController* flow_controller() { return &flow_controller_; }
- // Called by the stream sequeuncer as bytes are added to the buffer.
+ // Called by the stream sequencer as bytes are added to the buffer.
void AddBytesBuffered(uint64 bytes);
- // Called by the stream sequeuncer as bytes are removed from the buffer.
+ // Called by the stream sequencer as bytes are removed from the buffer.
void RemoveBytesBuffered(uint64 bytes);
- // Called when bytese are sent to the peer.
+ // Called when bytes are sent to the peer.
void AddBytesSent(uint64 bytes);
- // Called by the stream sequeuncer as bytes are consumed from the buffer.
+ // Called by the stream sequencer as bytes are consumed from the buffer.
+ // If our receive window has dropped below the threshold, then send a
+ // WINDOW_UPDATE frame.
void AddBytesConsumed(uint64 bytes);
// Returns true if the stream is flow control blocked, by the stream flow
« no previous file with comments | « net/quic/quic_stream_sequencer.cc ('k') | net/quic/reliable_quic_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698