Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: net/quic/quic_stream_sequencer.cc

Issue 308363002: Remove unnecessary MaybeSendWindowUpdate from ReliableQuicStream: always (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | net/quic/reliable_quic_stream.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_stream_sequencer.h" 5 #include "net/quic/quic_stream_sequencer.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 if (!blocked_ && byte_offset == num_bytes_consumed_) { 61 if (!blocked_ && byte_offset == num_bytes_consumed_) {
62 DVLOG(1) << "Processing byte offset " << byte_offset; 62 DVLOG(1) << "Processing byte offset " << byte_offset;
63 size_t bytes_consumed = 0; 63 size_t bytes_consumed = 0;
64 for (size_t i = 0; i < data.Size(); ++i) { 64 for (size_t i = 0; i < data.Size(); ++i) {
65 bytes_consumed += stream_->ProcessRawData( 65 bytes_consumed += stream_->ProcessRawData(
66 static_cast<char*>(data.iovec()[i].iov_base), 66 static_cast<char*>(data.iovec()[i].iov_base),
67 data.iovec()[i].iov_len); 67 data.iovec()[i].iov_len);
68 } 68 }
69 num_bytes_consumed_ += bytes_consumed; 69 num_bytes_consumed_ += bytes_consumed;
70 stream_->AddBytesConsumed(bytes_consumed); 70 stream_->AddBytesConsumed(bytes_consumed);
71 stream_->MaybeSendWindowUpdate();
72 71
73 if (MaybeCloseStream()) { 72 if (MaybeCloseStream()) {
74 return true; 73 return true;
75 } 74 }
76 if (bytes_consumed > data_len) { 75 if (bytes_consumed > data_len) {
77 stream_->Reset(QUIC_ERROR_PROCESSING_STREAM); 76 stream_->Reset(QUIC_ERROR_PROCESSING_STREAM);
78 return false; 77 return false;
79 } else if (bytes_consumed == data_len) { 78 } else if (bytes_consumed == data_len) {
80 FlushBufferedFrames(); 79 FlushBufferedFrames();
81 return true; // it's safe to ack this frame. 80 return true; // it's safe to ack this frame.
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 } 241 }
243 MaybeCloseStream(); 242 MaybeCloseStream();
244 } 243 }
245 244
246 void QuicStreamSequencer::RecordBytesConsumed(size_t bytes_consumed) { 245 void QuicStreamSequencer::RecordBytesConsumed(size_t bytes_consumed) {
247 num_bytes_consumed_ += bytes_consumed; 246 num_bytes_consumed_ += bytes_consumed;
248 num_bytes_buffered_ -= bytes_consumed; 247 num_bytes_buffered_ -= bytes_consumed;
249 248
250 stream_->AddBytesConsumed(bytes_consumed); 249 stream_->AddBytesConsumed(bytes_consumed);
251 stream_->RemoveBytesBuffered(bytes_consumed); 250 stream_->RemoveBytesBuffered(bytes_consumed);
252 stream_->MaybeSendWindowUpdate();
253 } 251 }
254 252
255 } // namespace net 253 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | net/quic/reliable_quic_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698