Issue 307713002: Refactor repainting logic to abstract away the specific repaint container.

Issue 307713002: Refactor repainting logic to abstract away the specific repaint container. (Closed)

Created:
6 years, 6 months ago by chrishtr

Modified:
6 years, 6 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Refactor repainting logic to abstract away the specific repaint container. In basically all cases it was calling containerForRepaint(), so no need to pass that extra argument. BUG=370664 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175015

Patch Set 1 #

Patch Set 2 : Simplify. #

Total comments: 2

Patch Set 3 : Responded to comments. #

Patch Set 4 : Fix. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -21 lines)			Patch
M	Source/core/rendering/RenderLayer.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderLayerModelObject.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderLayerRepainter.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderLayerRepainter.cpp	View		4 chunks	+14 lines, -8 lines	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderObject.cpp	View	1 2 3	3 chunks	+13 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderReplaced.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/compositing/RenderLayerCompositor.cpp	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

leviw_travelin_and_unemployed

Everything looks good except the point I called out. https://codereview.chromium.org/307713002/diff/20001/Source/core/rendering/RenderObject.cpp File Source/core/rendering/RenderObject.cpp (right): https://codereview.chromium.org/307713002/diff/20001/Source/core/rendering/RenderObject.cpp#newcode1482 Source/core/rendering/RenderObject.cpp:1482: ...

6 years, 6 months ago (2014-05-28 20:35:56 UTC) #2

chrishtr

Looks ok? Code is a little more complicated but avoids the perf issue. https://codereview.chromium.org/307713002/diff/20001/Source/core/rendering/RenderObject.cpp File ...

6 years, 6 months ago (2014-05-28 22:56:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/307713002/60001

6 years, 6 months ago (2014-05-28 23:16:03 UTC) #6

Message was sent while issue was closed.

Change committed as 175015

Expand Messages | Collapse Messages