Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 307713002: Refactor repainting logic to abstract away the specific repaint container. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderLayerRepainter.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
799 void getTextDecorations(unsigned decorations, AppliedTextDecoration& underli ne, AppliedTextDecoration& overline, AppliedTextDecoration& linethrough, bool qu irksMode = false, bool firstlineStyle = false); 799 void getTextDecorations(unsigned decorations, AppliedTextDecoration& underli ne, AppliedTextDecoration& overline, AppliedTextDecoration& linethrough, bool qu irksMode = false, bool firstlineStyle = false);
800 800
801 // Return the RenderLayerModelObject in the container chain which is respons ible for painting this object, or 0 801 // Return the RenderLayerModelObject in the container chain which is respons ible for painting this object, or 0
802 // if painting is root-relative. This is the container that should be passed to the 'forRepaint' 802 // if painting is root-relative. This is the container that should be passed to the 'forRepaint'
803 // methods. 803 // methods.
804 const RenderLayerModelObject* containerForRepaint() const; 804 const RenderLayerModelObject* containerForRepaint() const;
805 const RenderLayerModelObject* enclosingCompositedContainer() const; 805 const RenderLayerModelObject* enclosingCompositedContainer() const;
806 const RenderLayerModelObject* adjustCompositedContainerForSpecialAncestors(c onst RenderLayerModelObject* repaintContainer) const; 806 const RenderLayerModelObject* adjustCompositedContainerForSpecialAncestors(c onst RenderLayerModelObject* repaintContainer) const;
807 bool isRepaintContainer() const; 807 bool isRepaintContainer() const;
808 808
809 // Returns the repaint rect for this RenderObject in the coordinate space of the composited layer that this RenderObject paints into, or the RenderView if n ot
810 // composited.
811 LayoutRect computeRepaintRect() const;
812
809 // Actually do the repaint of rect r for this object which has been computed in the coordinate space 813 // Actually do the repaint of rect r for this object which has been computed in the coordinate space
810 // of repaintContainer. If repaintContainer is 0, repaint via the view. 814 // of repaintContainer. If repaintContainer is 0, repaint via the view.
811 void repaintUsingContainer(const RenderLayerModelObject* repaintContainer, c onst IntRect&, InvalidationReason) const; 815 void repaintUsingContainer(const RenderLayerModelObject* repaintContainer, c onst IntRect&, InvalidationReason) const;
812 816
813 // Repaint the entire object. Called when, e.g., the color of a border chan ges, or when a border 817 // Repaint the entire object. Called when, e.g., the color of a border chan ges, or when a border
814 // style changes. 818 // style changes.
815 void repaint() const; 819 void repaint() const;
816 820
817 // Repaint a specific subrectangle within a given object. The rect |r| is i n the object's coordinate space. 821 // Repaint a specific subrectangle within a given object. The rect |r| is i n the object's coordinate space.
818 void repaintRectangle(const LayoutRect&) const; 822 void repaintRectangle(const LayoutRect&) const;
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
1066 // containerRect is a rect that has already been added for the currentLayer which is likely to 1070 // containerRect is a rect that has already been added for the currentLayer which is likely to
1067 // be a container for child elements. Any rect wholly contained by container Rect can be 1071 // be a container for child elements. Any rect wholly contained by container Rect can be
1068 // skipped. 1072 // skipped.
1069 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer* cur rentLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) cons t; 1073 virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer* cur rentLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) cons t;
1070 1074
1071 // Add hit-test rects for this renderer only to the provided list. layerOffs et is the offset 1075 // Add hit-test rects for this renderer only to the provided list. layerOffs et is the offset
1072 // of this renderer within the current layer that should be used for each re sult. 1076 // of this renderer within the current layer that should be used for each re sult.
1073 virtual void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOffset) const { }; 1077 virtual void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOffset) const { };
1074 1078
1075 private: 1079 private:
1080 LayoutRect computeRepaintRectInternal(const RenderLayerModelObject* repaintC ontainer) const;
1081
1076 RenderBlock* containerForFixedPosition(const RenderLayerModelObject* repaint Container = 0, bool* repaintContainerSkipped = 0) const; 1082 RenderBlock* containerForFixedPosition(const RenderLayerModelObject* repaint Container = 0, bool* repaintContainerSkipped = 0) const;
1077 1083
1078 RenderFlowThread* locateFlowThreadContainingBlock() const; 1084 RenderFlowThread* locateFlowThreadContainingBlock() const;
1079 void removeFromRenderFlowThread(); 1085 void removeFromRenderFlowThread();
1080 void removeFromRenderFlowThreadRecursive(RenderFlowThread*); 1086 void removeFromRenderFlowThreadRecursive(RenderFlowThread*);
1081 1087
1082 bool hasImmediateNonWhitespaceTextChildOrPropertiesDependentOnColor() const; 1088 bool hasImmediateNonWhitespaceTextChildOrPropertiesDependentOnColor() const;
1083 1089
1084 RenderStyle* cachedFirstLineStyle() const; 1090 RenderStyle* cachedFirstLineStyle() const;
1085 StyleDifference adjustStyleDifference(StyleDifference, unsigned contextSensi tiveProperties) const; 1091 StyleDifference adjustStyleDifference(StyleDifference, unsigned contextSensi tiveProperties) const;
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
1478 void showTree(const WebCore::RenderObject*); 1484 void showTree(const WebCore::RenderObject*);
1479 void showLineTree(const WebCore::RenderObject*); 1485 void showLineTree(const WebCore::RenderObject*);
1480 void showRenderTree(const WebCore::RenderObject* object1); 1486 void showRenderTree(const WebCore::RenderObject* object1);
1481 // We don't make object2 an optional parameter so that showRenderTree 1487 // We don't make object2 an optional parameter so that showRenderTree
1482 // can be called from gdb easily. 1488 // can be called from gdb easily.
1483 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2); 1489 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2);
1484 1490
1485 #endif 1491 #endif
1486 1492
1487 #endif // RenderObject_h 1493 #endif // RenderObject_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayerRepainter.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698