Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 306063005: Use createV8Entry() and toV8Value() with context and isolate defined in WebDOMFileSystem. (Closed)

Created:
6 years, 6 months ago by tasak
Modified:
6 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, jam, yoshiki+watch_chromium.org, nhiroki, rginda+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi
Visibility:
Public.

Description

Use createV8Entry() and toV8Value() with context and isolate defined in WebDOMFileSystem. Should not use createV8Entry() and toV8Value() without cntext and isolate. Need to provide these information explicitly. BUG=369451 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M chrome/renderer/extensions/file_browser_handler_custom_bindings.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/file_browser_private_custom_bindings.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/media_galleries_custom_bindings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/sync_file_system_custom_bindings.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/renderer/pepper/resource_converter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/renderer/file_system_natives.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
tasak
6 years, 6 months ago (2014-06-02 08:12:40 UTC) #1
haraken
LGTM (though I'm not an OWNER).
6 years, 6 months ago (2014-06-02 08:15:21 UTC) #2
tasak
Would you review this CL?
6 years, 6 months ago (2014-06-05 04:01:45 UTC) #3
tzik
lgtm
6 years, 6 months ago (2014-06-05 05:25:34 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-05 06:55:23 UTC) #5
tasak
Thank you.
6 years, 6 months ago (2014-06-05 07:07:53 UTC) #6
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-06-05 07:07:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/306063005/1
6 years, 6 months ago (2014-06-05 07:10:30 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 08:25:15 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 08:28:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71810)
6 years, 6 months ago (2014-06-05 08:28:29 UTC) #11
tasak
benwells, would you review this CL? I need lgtm from extension's OWNER.
6 years, 6 months ago (2014-06-05 10:26:22 UTC) #12
benwells
lgtm
6 years, 6 months ago (2014-06-05 22:09:13 UTC) #13
tasak
On 2014/06/05 22:09:13, benwells wrote: > lgtm Thank you.
6 years, 6 months ago (2014-06-06 01:17:02 UTC) #14
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-06-06 01:17:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/306063005/1
6 years, 6 months ago (2014-06-06 01:18:40 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 01:26:15 UTC) #17
Message was sent while issue was closed.
Change committed as 275291

Powered by Google App Engine
This is Rietveld 408576698