chrome/renderer/extensions/file_browser_private_custom_bindings.cc - Issue 306063005: Use createV8Entry() and toV8Value() with context and isolate defined in WebDOMFileSystem.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/extensions/file_browser_private_custom_bindings.cc

Issue 306063005: Use createV8Entry() and toV8Value() with context and isolate defined in WebDOMFileSystem. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/renderer/extensions/file_browser_handler_custom_bindings.cc ('k') | chrome/renderer/extensions/media_galleries_custom_bindings.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/renderer/extensions/file_browser_private_custom_bindings.h"	5 #include "chrome/renderer/extensions/file_browser_private_custom_bindings.h"

6	6

7 #include <string>	7 #include <string>

8	8

9 #include "base/basictypes.h"	9 #include "base/basictypes.h"

10 #include "base/logging.h"	10 #include "base/logging.h"

(...skipping 19 matching lines...) Expand all Loading...
30 DCHECK(args.Length() == 2);	30 DCHECK(args.Length() == 2);

31 DCHECK(args[0]->IsString());	31 DCHECK(args[0]->IsString());

32 DCHECK(args[1]->IsString());	32 DCHECK(args[1]->IsString());

33 std::string name(*v8::String::Utf8Value(args[0]));	33 std::string name(*v8::String::Utf8Value(args[0]));

34 std::string root_url(*v8::String::Utf8Value(args[1]));	34 std::string root_url(*v8::String::Utf8Value(args[1]));

35	35

36 blink::WebLocalFrame* webframe =	36 blink::WebLocalFrame* webframe =

37 blink::WebLocalFrame::frameForContext(context()->v8_context());	37 blink::WebLocalFrame::frameForContext(context()->v8_context());

38 DCHECK(webframe);	38 DCHECK(webframe);

39 args.GetReturnValue().Set(	39 args.GetReturnValue().Set(

40 blink::WebDOMFileSystem::create(	40 blink::WebDOMFileSystem::create(webframe,

41 webframe,	41 blink::WebFileSystemTypeExternal,

42 blink::WebFileSystemTypeExternal,	42 blink::WebString::fromUTF8(name),

43 blink::WebString::fromUTF8(name),	43 GURL(root_url))

44 GURL(root_url)).toV8Value());	44 .toV8Value(args.Holder(), args.GetIsolate()));

45 }	45 }

46	46

47 } // namespace extensions	47 } // namespace extensions

OLD	NEW