Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: chrome/renderer/extensions/sync_file_system_custom_bindings.cc

Issue 306063005: Use createV8Entry() and toV8Value() with context and isolate defined in WebDOMFileSystem. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/sync_file_system_custom_bindings.h" 5 #include "chrome/renderer/extensions/sync_file_system_custom_bindings.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "extensions/renderer/script_context.h" 9 #include "extensions/renderer/script_context.h"
10 #include "third_party/WebKit/public/web/WebDOMFileSystem.h" 10 #include "third_party/WebKit/public/web/WebDOMFileSystem.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 } 45 }
46 std::string root_url(*v8::String::Utf8Value(args[1])); 46 std::string root_url(*v8::String::Utf8Value(args[1]));
47 if (root_url.empty()) { 47 if (root_url.empty()) {
48 NOTREACHED(); 48 NOTREACHED();
49 return; 49 return;
50 } 50 }
51 51
52 blink::WebLocalFrame* webframe = 52 blink::WebLocalFrame* webframe =
53 blink::WebLocalFrame::frameForContext(context()->v8_context()); 53 blink::WebLocalFrame::frameForContext(context()->v8_context());
54 args.GetReturnValue().Set( 54 args.GetReturnValue().Set(
55 blink::WebDOMFileSystem::create( 55 blink::WebDOMFileSystem::create(webframe,
56 webframe, 56 blink::WebFileSystemTypeExternal,
57 blink::WebFileSystemTypeExternal, 57 blink::WebString::fromUTF8(name),
58 blink::WebString::fromUTF8(name), 58 GURL(root_url))
59 GURL(root_url)).toV8Value()); 59 .toV8Value(args.Holder(), args.GetIsolate()));
60 } 60 }
61 61
62 } // namespace extensions 62 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/media_galleries_custom_bindings.cc ('k') | content/renderer/pepper/resource_converter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698