chrome/renderer/extensions/file_browser_private_custom_bindings.cc - Issue 306063005: Use createV8Entry() and toV8Value() with context and isolate defined in WebDOMFileSystem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/file_browser_private_custom_bindings.cc

Issue 306063005: Use createV8Entry() and toV8Value() with context and isolate defined in WebDOMFileSystem. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/file_browser_handler_custom_bindings.cc ('k') | chrome/renderer/extensions/media_galleries_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/file_browser_private_custom_bindings.cc

diff --git a/chrome/renderer/extensions/file_browser_private_custom_bindings.cc b/chrome/renderer/extensions/file_browser_private_custom_bindings.cc

index 20afb3d50cffc6c7e33f700d616dfe25703e041e..ff65c93adc47d69d5cd14ba1b8b3cf1ae3c632a8 100644

--- a/chrome/renderer/extensions/file_browser_private_custom_bindings.cc

+++ b/chrome/renderer/extensions/file_browser_private_custom_bindings.cc

@@ -37,11 +37,11 @@ void FileBrowserPrivateCustomBindings::GetFileSystem(

blink::WebLocalFrame::frameForContext(context()->v8_context());

DCHECK(webframe);

args.GetReturnValue().Set(

- blink::WebDOMFileSystem::create(

- webframe,

- blink::WebFileSystemTypeExternal,

- blink::WebString::fromUTF8(name),

- GURL(root_url)).toV8Value());

+ blink::WebDOMFileSystem::create(webframe,

+ blink::WebFileSystemTypeExternal,

+ blink::WebString::fromUTF8(name),

+ GURL(root_url))

+ .toV8Value(args.Holder(), args.GetIsolate()));

}

} // namespace extensions