Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 304603003: Make source map location information more readable. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make source map location information more readable. This changes "file:1:2" to "line 1, column 2 of file" and ":1:2" to "line 1, column 2" in [SourceFile.getLocationMessage]. The more machine-readable colon-separated format doesn't make sense for a message intended for humans. Since [Location.formatString] seems more likely to be consumed by machines, its format was left as-is. This also prepares version 0.9.1 for release. This was previously submitted as r36603. That caused buildbot errors and was rolled back by r36615. This CL fixes the test errors in r36603. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=36717

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -42 lines) Patch
M pkg/csslib/lib/src/messages.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/csslib/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/csslib/test/error_test.dart View 14 chunks +15 lines, -14 lines 0 comments Download
M pkg/csslib/test/selector_test.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/csslib/test/var_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
A pkg/source_maps/CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/source_maps/lib/span.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/source_maps/pubspec.yaml View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/source_maps/test/span_test.dart View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
The actual source_map package is unchanged from the original CL. The only real changes are ...
5 years, 5 months ago (2014-05-27 21:29:05 UTC) #1
Siggi Cherem (dart-lang)
lgtm
5 years, 5 months ago (2014-05-27 22:46:49 UTC) #2
nweiz
5 years, 5 months ago (2014-05-27 23:01:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36717 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698