Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: pkg/source_maps/lib/span.dart

Issue 304603003: Make source map location information more readable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/source_maps/CHANGELOG.md ('k') | pkg/source_maps/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/source_maps/lib/span.dart
diff --git a/pkg/source_maps/lib/span.dart b/pkg/source_maps/lib/span.dart
index 17ccd272d3cca1a3ac549023a9e4a24d51e6ef83..f47e08eb629e81ce2c05a4414dcd5eee89f329cc 100644
--- a/pkg/source_maps/lib/span.dart
+++ b/pkg/source_maps/lib/span.dart
@@ -7,6 +7,8 @@ library source_maps.span;
import 'dart:math' show min, max;
+import 'package:path/path.dart' as p;
+
import 'src/utils.dart';
/// A simple class that describe a segment of source text.
@@ -252,8 +254,8 @@ class SourceFile {
var line = getLine(start);
var column = getColumn(line, start);
- var src = url == null ? '' : url;
- var msg = '$src:${line + 1}:${column + 1}: $message';
+ var source = url == null ? '' : ' of ${p.prettyUri(url)}';
+ var msg = 'line ${line + 1}, column ${column + 1}$source: $message';
if (_decodedChars == null) {
// We don't have any text to include, so exit.
« no previous file with comments | « pkg/source_maps/CHANGELOG.md ('k') | pkg/source_maps/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698