Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: pkg/source_maps/test/span_test.dart

Issue 304603003: Make source map location information more readable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/source_maps/pubspec.yaml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/source_maps/test/span_test.dart
diff --git a/pkg/source_maps/test/span_test.dart b/pkg/source_maps/test/span_test.dart
index da3e063ef421a2f3cfed58ce33f9807d1a375c4d..190b7a66b4fd43e526fd31767067c3367b626ac2 100644
--- a/pkg/source_maps/test/span_test.dart
+++ b/pkg/source_maps/test/span_test.dart
@@ -72,7 +72,7 @@ main() {
group('location message', () {
test('first line', () {
expect(file.getLocationMessage('the message', 1, 3),
- 'file:1:2: the message\n'
+ 'line 1, column 2 of file: the message\n'
'+23456789_\n'
' ^^');
});
@@ -81,7 +81,7 @@ main() {
// fifth line (including 4 new lines), columns 2 .. 11
var line = 10 + 80 + 31 + 27 + 4;
expect(file.getLocationMessage('the message', line + 2, line + 11),
- 'file:5:3: the message\n'
+ 'line 5, column 3 of file: the message\n'
'1234+6789_1234\n'
' ^^^^^^^^^');
});
@@ -90,7 +90,7 @@ main() {
var line = 10 + 80 + 31 + 27 + 4;
expect(new SourceFile.text(null, TEST_FILE).getLocationMessage(
'the message', line + 2, line + 11),
- ':5:3: the message\n'
+ 'line 5, column 3: the message\n'
'1234+6789_1234\n'
' ^^^^^^^^^');
});
@@ -100,7 +100,7 @@ main() {
int index = TEST_FILE.lastIndexOf('\n');
var start = TEST_FILE.lastIndexOf('\n', index - 1) - 3;
expect(file.getLocationMessage('the message', start, start + 2),
- 'file:11:41: the message\n'
+ 'line 11, column 41 of file: the message\n'
'123456789_+23456789_123456789_123456789_123\n'
' ^^');
});
@@ -108,7 +108,7 @@ main() {
test('last line', () {
var start = TEST_FILE.lastIndexOf('\n') - 2;
expect(file.getLocationMessage('the message', start, start + 1),
- 'file:12:28: the message\n'
+ 'line 12, column 28 of file: the message\n'
'123456789_1+3456789_123456789\n'
' ^');
});
@@ -120,7 +120,7 @@ main() {
test('penultimate line', () {
var start = text.lastIndexOf('\n') - 3;
expect(file2.getLocationMessage('the message', start, start + 2),
- 'file:11:41: the message\n'
+ 'line 11, column 41 of file: the message\n'
'123456789_+23456789_123456789_123456789_123\n'
' ^^');
});
@@ -128,7 +128,7 @@ main() {
test('last line', () {
var start = text.length - 2;
expect(file2.getLocationMessage('the message', start, start + 1),
- 'file:12:28: the message\n'
+ 'line 12, column 28 of file: the message\n'
'123456789_1+3456789_123456789\n'
' ^');
});
@@ -139,7 +139,7 @@ main() {
int start = text.indexOf(' ') + 1;
var file2 = new SourceFile.text('file', text);
expect(file2.getLocationMessage('the message', start, start + 2),
- 'file:1:${start + 1}: the message\n'
+ 'line 1, column ${start + 1} of file: the message\n'
'this is a single line\n'
' ^^');
});
@@ -178,7 +178,7 @@ main() {
var line = 10 + 80 + 31 + 27 + 4;
expect(span(line + 2, line + 11).getLocationMessage('the message'),
- 'file:5:3: the message\n'
+ 'line 5, column 3 of file: the message\n'
'1234+6789_1234\n'
' ^^^^^^^^^');
@@ -226,7 +226,7 @@ main() {
test('range check for large offsets', () {
var start = TEST_FILE.length;
expect(file.getLocationMessage('the message', start, start + 9),
- 'file:13:1: the message\n');
+ 'line 13, column 1 of file: the message\n');
});
group('file segment', () {
@@ -296,7 +296,7 @@ main() {
test('past segment, past its line', () {
var start = TEST_FILE.length - 2;
expect(file.getLocationMessage('the message', start, start + 1),
- 'file:12:29: the message\n'
+ 'line 12, column 29 of file: the message\n'
'123456789_1+3456789_123456789\n'
' ^');
@@ -304,7 +304,7 @@ main() {
// about the 10 lines it has (and nothing about the possible extra lines
// afterwards)
expect(segment.getLocationMessage('the message', start, start + 1),
- 'file:11:1: the message\n');
+ 'line 11, column 1 of file: the message\n');
});
});
});
« no previous file with comments | « pkg/source_maps/pubspec.yaml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698