Make source map location information more readable.

pkg/csslib/test/error_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library error_test;
 
 import 'package:unittest/unittest.dart';
 import 'testing.dart';
 import 'package:csslib/src/messages.dart';
 
 /**
  * Test for unsupported font-weights values of bolder, lighter and inherit.
  */
 void testUnsupportedFontWeights() {
   var errors = [];
 
   // TODO(terry): Need to support bolder.
   // font-weight value bolder.
   var input = ".foobar { font-weight: bolder; }";
   var stylesheet = parseCss(input, errors: errors);
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(), r'''
-error :1:24: Unknown property value bolder
+error on line 1, column 24: Unknown property value bolder
 .foobar { font-weight: bolder; }
                        ^^^^^^''');
   expect(stylesheet != null, true);
 
   expect(prettyPrint(stylesheet), r'''
 .foobar {
   font-weight: bolder;
 }''');
 
   // TODO(terry): Need to support lighter.
   // font-weight value lighter.
   input = ".foobar { font-weight: lighter; }";
   stylesheet = parseCss(input, errors: errors..clear());
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(), r'''
-error :1:24: Unknown property value lighter
+error on line 1, column 24: Unknown property value lighter
 .foobar { font-weight: lighter; }
                        ^^^^^^^''');
   expect(stylesheet != null, true);
   expect(prettyPrint(stylesheet), r'''
 .foobar {
   font-weight: lighter;
 }''');
 
   // TODO(terry): Need to support inherit.
   // font-weight value inherit.
   input = ".foobar { font-weight: inherit; }";
   stylesheet = parseCss(input, errors: errors..clear());
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(), r'''
-error :1:24: Unknown property value inherit
+error on line 1, column 24: Unknown property value inherit
 .foobar { font-weight: inherit; }
                        ^^^^^^^''');
   expect(stylesheet != null, true);
   expect(prettyPrint(stylesheet), r'''
 .foobar {
   font-weight: inherit;
 }''');
 }
 
 /**
  * Test for unsupported line-height values of units other than px, pt and
  * inherit.
  */
 void testUnsupportedLineHeights() {
   var errors = [];
 
   // line-height value in percentge unit.
   var input = ".foobar { line-height: 120%; }";
   var stylesheet = parseCss(input, errors: errors);
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(), r'''
-error :1:24: Unexpected value for line-height
+error on line 1, column 24: Unexpected value for line-height
 .foobar { line-height: 120%; }
                        ^^^''');
   expect(stylesheet != null, true);
   expect(prettyPrint(stylesheet), r'''
 .foobar {
   line-height: 120%;
 }''');
 
   // TODO(terry): Need to support all units.
   // line-height value in cm unit.
   input = ".foobar { line-height: 20cm; }";
   stylesheet = parseCss(input, errors: errors..clear());
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(), r'''
-error :1:24: Unexpected unit for line-height
+error on line 1, column 24: Unexpected unit for line-height
 .foobar { line-height: 20cm; }
                        ^^''');
   expect(stylesheet != null, true);
   expect(prettyPrint(stylesheet), r'''
 .foobar {
   line-height: 20cm;
 }''');
 
   // TODO(terry): Need to support inherit.
   // line-height value inherit.
   input = ".foobar { line-height: inherit; }";
   stylesheet = parseCss(input, errors: errors..clear());
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(), r'''
-error :1:24: Unknown property value inherit
+error on line 1, column 24: Unknown property value inherit
 .foobar { line-height: inherit; }
                        ^^^^^^^''');
   expect(stylesheet != null, true);
   expect(prettyPrint(stylesheet), r'''
 .foobar {
   line-height: inherit;
 }''');
 }
 
 /** Test for bad selectors. */
 void testBadSelectors() {
   var errors = [];
 
   // Invalid id selector.
   var input = "# foo { color: #ff00ff; }";
   var stylesheet = parseCss(input, errors: errors);
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(), r'''
-error :1:1: Not a valid ID selector expected #id
+error on line 1, column 1: Not a valid ID selector expected #id
 # foo { color: #ff00ff; }
 ^''');
   expect(stylesheet != null, true);
   expect(prettyPrint(stylesheet), r'''
 # foo {
   color: #f0f;
 }''');
 
   // Invalid class selector.
   input = ". foo { color: #ff00ff; }";
   stylesheet = parseCss(input, errors: errors..clear());
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(), r'''
-error :1:1: Not a valid class selector expected .className
+error on line 1, column 1: Not a valid class selector expected .className
 . foo { color: #ff00ff; }
 ^''');
   expect(stylesheet != null, true);
   expect(prettyPrint(stylesheet), r'''
 . foo {
   color: #f0f;
 }''');
 }
 
 /** Test for bad hex values. */
 void testBadHexValues() {
   var errors = [];
 
   // Invalid hex value.
   var input = ".foobar { color: #AH787; }";
   var stylesheet = parseCss(input, errors: errors);
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(), r'''
-error :1:18: Bad hex number
+error on line 1, column 18: Bad hex number
 .foobar { color: #AH787; }
                  ^^^^^^''');
   expect(stylesheet != null, true);
   expect(prettyPrint(stylesheet), r'''
 .foobar {
   color: #AH787;
 }''');
 
   // Bad color constant.
   input = ".foobar { color: redder; }";
   stylesheet = parseCss(input, errors: errors..clear());
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(), r'''
-error :1:18: Unknown property value redder
+error on line 1, column 18: Unknown property value redder
 .foobar { color: redder; }
                  ^^^^^^''');
 
   expect(stylesheet != null, true);
   expect(prettyPrint(stylesheet), r'''
 .foobar {
   color: redder;
 }''');
 
   // Bad hex color #<space>ffffff.
   input = ".foobar { color: # ffffff; }";
   stylesheet = parseCss(input, errors: errors..clear());
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(), r'''
-error :1:18: Expected hex number
+error on line 1, column 18: Expected hex number
 .foobar { color: # ffffff; }
                  ^''');
 
   expect(stylesheet != null, true);
   expect(prettyPrint(stylesheet), r'''
 .foobar {
   color: # ffffff;
 }''');
 
   // Bad hex color #<space>123fff.
   input = ".foobar { color: # 123fff; }";
   stylesheet = parseCss(input, errors: errors..clear());
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(), r'''
-error :1:18: Expected hex number
+error on line 1, column 18: Expected hex number
 .foobar { color: # 123fff; }
                  ^''');
 
   expect(stylesheet != null, true);
 
   // Formating is off with an extra space.  However, the entire value is bad
   // and isn't processed anyway.
   expect(prettyPrint(stylesheet), r'''
 .foobar {
   color: # 123 fff;
 }''');
 
 }
 
 void testBadUnicode() {
   var errors = [];
   final String input = '''
 @font-face {
   src: url(fonts/BBCBengali.ttf) format("opentype");
   unicode-range: U+400-200;
 }''';
 
   var stylesheet = parseCss(input, errors: errors);
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(),
-      'error :3:20: unicode first range can not be greater than last\n'
+      'error on line 3, column 20: unicode first range can not be greater than '
+        'last\n'
       '  unicode-range: U+400-200;\n'
       '                   ^^^^^^^');
 
   final String input2 = '''
 @font-face {
   src: url(fonts/BBCBengali.ttf) format("opentype");
   unicode-range: U+12FFFF;
 }''';
 
   stylesheet = parseCss(input2, errors: errors..clear());
 
   expect(errors.isEmpty, false);
   expect(errors[0].toString(),
-      'error :3:20: unicode range must be less than 10FFFF\n'
+      'error on line 3, column 20: unicode range must be less than 10FFFF\n'
       '  unicode-range: U+12FFFF;\n'
       '                   ^^^^^^');
 }
 
 void testBadNesting() {
   var errors = [];
 
   // Test for bad declaration in a nested rule.
   final String input = '''
 div {
@@ skipping 78 matching lines @@
 }
 
 main() {
   test('font-weight value errors', testUnsupportedFontWeights);
   test('line-height value errors', testUnsupportedLineHeights);
   test('bad selectors', testBadSelectors);
   test('bad Hex values', testBadHexValues);
   test('bad unicode ranges', testBadUnicode);
   test('nested rules', testBadNesting);
 }