Initial work towards public Android recipes

Initial work towards public Android recipes

BUG=338501
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=273775

[luqui, 2014-05-27 18:39:34]

lgtm. N.B. caveat

https://codereview.chromium.org/303513002/diff/1/scripts/slave/recipe_modules...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/303513002/diff/1/scripts/slave/recipe_modules...
scripts/slave/recipe_modules/chromium_android/api.py:206: def findbugs(self):
This is going to conflict with this change once I reland it:
https://codereview.chromium.org/297143002.  In short, let's get rid of this
INTERNAL garbage and have chromium_android's findbugs just do what is required
for the public findbugs.  C**** can do what it needs to in build_internal.

[Paweł Hajdan Jr., 2014-05-28 12:53:21]

https://codereview.chromium.org/303513002/diff/1/scripts/slave/recipe_modules...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/303513002/diff/1/scripts/slave/recipe_modules...
scripts/slave/recipe_modules/chromium_android/api.py:206: def findbugs(self):
On 2014/05/27 18:39:35, luqui wrote:
> This is going to conflict with this change once I reland it:
> https://codereview.chromium.org/297143002.  In short, let's get rid of this
> INTERNAL garbage and have chromium_android's findbugs just do what is required
> for the public findbugs.  C**** can do what it needs to in build_internal.

Done.

[Paweł Hajdan Jr., 2014-05-28 12:57:24]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-05-28 12:57:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/303513002/20001

[commit-bot: I haz the power, 2014-05-28 12:57:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 12:57:46]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Paweł Hajdan Jr., 2014-05-28 13:35:38]

+Michael for full committer's review.

[Michael Achenbach, 2014-05-28 14:23:26]

LGTM - mostly rubberstamp - with comments:

https://codereview.chromium.org/303513002/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/303513002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium_android/api.py:214:
self.m.path['checkout'].join('out'),
Just to make sure: The files are not in e.g. out/Release?

The out dir might also be more formally in self.m.chromium.c.build_dir.

https://codereview.chromium.org/303513002/diff/20001/scripts/slave/recipes/ch...
File scripts/slave/recipes/chromium.py (right):

https://codereview.chromium.org/303513002/diff/20001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium.py:1604:
**bot_config.get('chromium_config_kwargs', {}))
Not totally sure how much sense it makes to add the chromium_config_kwargs to
the android_config. Most of the variables are different. Well, BUILD_CONFIG is
the same. But it makes it a bit difficult to follow what goes from where to
where.

[Paweł Hajdan Jr., 2014-05-30 09:49:00]

https://codereview.chromium.org/303513002/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/303513002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium_android/api.py:214:
self.m.path['checkout'].join('out'),
On 2014/05/28 14:23:27, Michael Achenbach wrote:
> Just to make sure: The files are not in e.g. out/Release?
> 
> The out dir might also be more formally in self.m.chromium.c.build_dir.

I don't know, this is just restoring public version of the code that got deleted
meanwhile.

https://codereview.chromium.org/303513002/diff/20001/scripts/slave/recipes/ch...
File scripts/slave/recipes/chromium.py (right):

https://codereview.chromium.org/303513002/diff/20001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium.py:1604:
**bot_config.get('chromium_config_kwargs', {}))
On 2014/05/28 14:23:27, Michael Achenbach wrote:
> Not totally sure how much sense it makes to add the chromium_config_kwargs to
> the android_config. Most of the variables are different. Well, BUILD_CONFIG is
> the same. But it makes it a bit difficult to follow what goes from where to
> where.

Yes, android build is quite messy. It seems to me the first step would be
migrating everything to recipes, so it's easier to refactor all these things.

[Paweł Hajdan Jr., 2014-05-30 09:49:04]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-05-30 09:49:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/303513002/40001

[commit-bot: I haz the power, 2014-05-30 09:50:39]

Change committed as 273775