Issue 297143002: Reland "Simplified android_builder and moved internal-only methods to internal module"

Issue 297143002: Reland "Simplified android_builder and moved internal-only methods to internal module" (Closed)

Created:
6 years, 7 months ago by luqui

Modified:
6 years, 6 months ago

Reviewers:
navabi1, iannucci, zty

CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master

Visibility:
Public.

More Reviews

Description

Reland "Simplified android_builder and moved internal-only methods to internal module" Original CL: https://codereview.chromium.org/296723004/ BUG=375007 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=273006

Patch Set 2 : Review comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+200 lines, -3574 lines)			Patch
M	scripts/slave/recipe_modules/chromium_android/api.py	View	1	5 chunks	+9 lines, -86 lines	0 comments	Download
M	scripts/slave/recipe_modules/chromium_android/example.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json	View		3 chunks	+40 lines, -2 lines	0 comments	Download
M	scripts/slave/recipe_modules/chromium_android/example.expected/coverage_builder_basic.json	View		3 chunks	+40 lines, -2 lines	0 comments	Download
M	scripts/slave/recipe_modules/chromium_android/example.expected/restart_usb_builder_basic.json	View		3 chunks	+40 lines, -2 lines	0 comments	Download
M	scripts/slave/recipe_modules/path/example.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/path/example.expected/linux.json	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/path/example.expected/mac.json	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/path/example.expected/win.json	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/android/android_builder.py	View		1 chunk	+12 lines, -121 lines	0 comments	Download
D	scripts/slave/recipes/android/android_builder.expected/arm_builder.json	View		1 chunk	+0 lines, -268 lines	0 comments	Download
D	scripts/slave/recipes/android/android_builder.expected/arm_builder_rel.json	View		1 chunk	+0 lines, -268 lines	0 comments	Download
D	scripts/slave/recipes/android/android_builder.expected/clang_builder.json	View		1 chunk	+0 lines, -300 lines	0 comments	Download
D	scripts/slave/recipes/android/android_builder.expected/clang_builder_findbugs_failure.json	View		1 chunk	+0 lines, -323 lines	0 comments	Download
D	scripts/slave/recipes/android/android_builder.expected/clang_release_builder.json	View		1 chunk	+0 lines, -307 lines	0 comments	Download
D	scripts/slave/recipes/android/android_builder.expected/component_builder.json	View		1 chunk	+0 lines, -268 lines	0 comments	Download
D	scripts/slave/recipes/android/android_builder.expected/dartium_builder.json	View		1 chunk	+0 lines, -201 lines	0 comments	Download
D	scripts/slave/recipes/android/android_builder.expected/main_builder.json	View		1 chunk	+0 lines, -268 lines	0 comments	Download
D	scripts/slave/recipes/android/android_builder.expected/mipsel_builder.json	View		1 chunk	+0 lines, -264 lines	0 comments	Download
D	scripts/slave/recipes/android/android_builder.expected/try_builder.json	View		1 chunk	+0 lines, -313 lines	0 comments	Download
D	scripts/slave/recipes/android/android_builder.expected/x86_builder.json	View		1 chunk	+0 lines, -268 lines	0 comments	Download
D	scripts/slave/recipes/android/android_builder.expected/x86_try_builder.json	View		1 chunk	+0 lines, -313 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

iannucci

rslgtm https://codereview.chromium.org/297143002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/297143002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#newcode75 scripts/slave/recipe_modules/chromium_android/api.py:75: # These are covered by build_internal. Bleh. -luqui ...

6 years, 6 months ago (2014-05-27 19:03:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/luqui@chromium.org/297143002/10001

6 years, 6 months ago (2014-05-27 19:20:33 UTC) #5

Message was sent while issue was closed.

Change committed as 273006

Expand Messages | Collapse Messages