Initial work towards public Android recipes

scripts/slave/recipe_modules/chromium_android/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 
 from slave import recipe_api
 
 class AndroidApi(recipe_api.RecipeApi):
   def __init__(self, **kwargs):
@@ skipping 185 matching lines @@
         [self.m.path['build'].join('scripts', 'slave', 'apply_svn_patch.py'),
          '-p', self.m.properties['patch_url'],
          '-r', self.internal_dir])
 
   def compile(self, **kwargs):
     assert 'env' not in kwargs, (
         "chromium_andoid compile clobbers env in keyword arguments")
     kwargs['env'] = self.get_env()
     return self.m.chromium.compile(**kwargs)
 
   def findbugs(self):

[luqui, 2014/05/27 18:39:35]

This is going to conflict with this change once I reland it:
https://codereview.chromium.org/297143002.  In short, let's get rid of this
INTERNAL garbage and have chromium_android's findbugs just do what is required
for the public findbugs.  C**** can do what it needs to in build_internal.

[Paweł Hajdan Jr., 2014/05/28 12:53:21]

Done.

-    assert self.c.INTERNAL, 'findbugs is only available on internal builds'
-    cmd = [
-        self.m.path['checkout'].join('build', 'android', 'findbugs_diff.py'),
-        '-b', self.internal_dir.join('bin', 'findbugs_filter'),
-        '-o', 'com.google.android.apps.chrome.-,org.chromium.-',
-    ]
-    yield self.m.step('findbugs internal', cmd, env=self.get_env())
+    cmd = [self.m.path['checkout'].join('build', 'android', 'findbugs_diff.py')]
+    if self.m.chromium.c.BUILD_CONFIG == 'Release':
+      cmd.append('--release-build')
+    if self.c.INTERNAL:
+      cmd.extend([
+          '-b', self.internal_dir.join('bin', 'findbugs_filter'),
+          '-o', 'com.google.android.apps.chrome.-,org.chromium.-',
+      ])
+      yield self.m.step('findbugs internal', cmd, env=self.get_env())
+    else:
+      yield self.m.step('findbugs', cmd, env=self.get_env())
 
     # If findbugs fails, there could be stale class files. Delete them, and
     # next run maybe we'll do better.
     if self.m.step_history.last_step().retcode != 0:
       yield self.m.path.rmwildcard(
           '*.class',
           self.m.path['checkout'].join('out'),
           always_run=True)
 
+    if not self.c.INTERNAL:
+      cmd = [self.m.path['checkout'].join('tools', 'android', 'findbugs_plugin',
+                 'test', 'run_findbugs_plugin_tests.py')]
+      if self.m.chromium.c.BUILD_CONFIG == 'Release':
+        cmd.append('--release-build')
+      yield self.m.step('findbugs_tests', cmd, env=self.get_env())
+
   def checkdeps(self):
     assert self.c.INTERNAL, 'checkdeps is only available on internal builds'
     yield self.m.step(
       'checkdeps',
       [self.m.path['checkout'].join('tools', 'checkdeps', 'checkdeps.py'),
        '--root=%s' % self.internal_dir],
       env=self.get_env())
 
+  def checklicenses(self):
+    yield self.m.step(
+      'check_licenses',
+      [self.m.path['checkout'].join('android_webview', 'tools',
+                                    'webview_licenses.py'),
+       'scan'],
+      env=self.get_env())
+
   def lint(self):
     assert self.c.INTERNAL, 'lint is only available on internal builds'
     yield self.m.step(
         'lint',
         [self.internal_dir.join('bin', 'lint.py')],
         env=self.get_env())
 
   def git_number(self):
     yield self.m.step(
         'git_number',
@@ skipping 99 matching lines @@
 
 
   def spawn_logcat_monitor(self):
     return self.m.step(
         'spawn_logcat_monitor',
         [self.m.path['build'].join('scripts', 'slave', 'daemonizer.py'),
          '--', self.c.cr_build_android.join('adb_logcat_monitor.py'),
          self.m.chromium.c.build_dir.join('logcat')],
         env=self.get_env(), can_fail_build=False)
 
-  def device_status_check(self, restart_usb=False):
+  def device_status_check(self, restart_usb=False, **kwargs):
     args = []
     if restart_usb:
       args = ['--restart-usb']
     yield self.m.step(
         'device_status_check',
         [self.m.path['checkout'].join('build', 'android', 'buildbot',
                               'bb_device_status_check.py')] + args,
-        env=self.get_env())
+        env=self.get_env(),
+        **kwargs)
 
-  def provision_devices(self):
+  def provision_devices(self, **kwargs):
     yield self.m.python(
         'provision_devices',
         self.m.path['checkout'].join(
             'build', 'android', 'provision_devices.py'),
         args=['-t', self.m.chromium.c.BUILD_CONFIG],
-        can_fail_build=False)
+        can_fail_build=False,
+        **kwargs)
 
   def detect_and_setup_devices(self):
     yield self.device_status_check()
     yield self.provision_devices()
 
     if self.c.INTERNAL:
       yield self.m.step(
           'setup_devices_for_testing',
           [self.internal_dir.join('build',  'setup_device_testing.py')],
           env=self.get_env(), can_fail_build=False)
@@ skipping 237 matching lines @@
 
     yield self.m.gsutil.upload(
         source=self.coverage_dir.join('coverage_html'),
         bucket='chrome-code-coverage',
         dest=gs_dest,
         args=['-R'],
         name='upload coverage report',
         link_name='Coverage report',
         always_run=True,
         **kwargs)