Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 303273008: Revert of Initial work to get ETC1 data up to the GPU (Closed)

Created:
6 years, 6 months ago by krajcevski
Modified:
6 years, 6 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Initial work to get ETC1 data up to the GPU (https://codereview.chromium.org/302783002/) Reason for revert: ETC1 linking problems with chrome. Original issue's description: > Initial work to get ETC1 data up to the GPU > > Committed: http://code.google.com/p/skia/source/detail?r=15001 TBR=bsalomon@google.com,robertphillips@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=15004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -252 lines) Patch
M gm/etc1bitmap.cpp View 2 chunks +5 lines, -14 lines 0 comments Download
M gyp/gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrContext.h View 2 chunks +3 lines, -3 lines 0 comments Download
M include/gpu/GrTypes.h View 1 chunk +0 lines, -20 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +3 lines, -16 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +10 lines, -25 lines 0 comments Download
M src/gpu/SkGr.cpp View 3 chunks +0 lines, -54 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 2 chunks +0 lines, -109 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
krajcevski
Created Revert of Initial work to get ETC1 data up to the GPU
6 years, 6 months ago (2014-05-30 20:32:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/303273008/1
6 years, 6 months ago (2014-05-30 20:33:18 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 20:33:19 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-05-30 20:33:19 UTC) #4
bsalomon
On 2014/05/30 20:33:19, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 6 months ago (2014-05-30 20:34:20 UTC) #5
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 6 months ago (2014-05-30 20:35:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/303273008/1
6 years, 6 months ago (2014-05-30 20:36:12 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 20:36:25 UTC) #8
Message was sent while issue was closed.
Change committed as 15004

Powered by Google App Engine
This is Rietveld 408576698