Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 303223008: Overlay expected and actual repaint rects for LayoutTests. (Closed)

Created:
6 years, 6 months ago by Xianzhu
Modified:
6 years, 6 months ago
Reviewers:
dsinclair, ojan, Dirk Pranke
CC:
blink-reviews
Visibility:
Public.

Description

Overlay expected and actual repaint rects for LayoutTests. Based on dsinclair@'s original patch https://codereview.chromium.org/174073002/ For the new world of text based repaint tests it can be hard to visualize how the repaint rects appear on the screen. This is a first pass at visualizing the difference between the old and new repaint rects when one of the text based repaint tests fail. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175182

Patch Set 1 : dsinclair@'s original version #

Patch Set 2 : New patch #

Patch Set 3 : Put "Show text" above "Expected/Actual Invalidations" #

Patch Set 4 : result_contains_repaint_rects should return bool #

Patch Set 5 : A small UI tweak #

Patch Set 6 : Add several small features #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -6 lines) Patch
M LayoutTests/fast/harness/resources/results-test.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/fast/harness/results.html View 1 6 chunks +13 lines, -4 lines 0 comments Download
M LayoutTests/fast/harness/results-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay.py View 1 2 3 4 5 1 chunk +204 lines, -0 lines 0 comments Download
A Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay_unittest.py View 1 1 chunk +54 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py View 1 4 chunks +9 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/models/test_results.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Xianzhu
A known issue of this patch: it can't handle layers with offset and transformations yet.
6 years, 6 months ago (2014-05-30 00:25:44 UTC) #1
dsinclair
non-owner lgtm
6 years, 6 months ago (2014-05-30 01:06:17 UTC) #2
esprehn
dpranke@ or ojan@ are your best reviewers for python code.
6 years, 6 months ago (2014-05-30 02:02:30 UTC) #3
Xianzhu
6 years, 6 months ago (2014-05-30 18:04:29 UTC) #4
Dirk Pranke
lgtm. thanks for working on this.
6 years, 6 months ago (2014-05-30 19:00:50 UTC) #5
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 6 months ago (2014-05-30 19:18:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/303223008/70001
6 years, 6 months ago (2014-05-30 19:19:40 UTC) #7
Xianzhu
The CQ bit was unchecked by wangxianzhu@chromium.org
6 years, 6 months ago (2014-05-30 21:42:49 UTC) #8
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 6 months ago (2014-05-30 23:11:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/303223008/90001
6 years, 6 months ago (2014-05-30 23:13:32 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 01:14:45 UTC) #11
Message was sent while issue was closed.
Change committed as 175182

Powered by Google App Engine
This is Rietveld 408576698