Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py - Issue 303223008: Overlay expected and actual repaint rects for LayoutTests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

Issue 303223008: Overlay expected and actual repaint rects for LayoutTests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add several small features Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay_unittest.py ('k') | Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py b/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

index 9fa219093a8d358e492c0cf948490a38e937c73c..c7cdde6abdf2e65ae8a325765531916308c355a0 100644

--- a/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

@@ -31,6 +31,7 @@ import logging

import re

import time

+from webkitpy.layout_tests.controllers import repaint_overlay

from webkitpy.layout_tests.controllers import test_result_writer

from webkitpy.layout_tests.port.driver import DeviceFailure, DriverInput, DriverOutput

from webkitpy.layout_tests.models import test_expectations

@@ -249,7 +250,8 @@ class SingleTestRunner(object):

if self._should_run_pixel_test:

failures.extend(self._compare_image(expected_driver_output, driver_output))

return TestResult(self._test_name, failures, driver_output.test_time, driver_output.has_stderr(),

- pid=driver_output.pid)

+ pid=driver_output.pid,

+ has_repaint_overlay=repaint_overlay.result_contains_repaint_rects(expected_driver_output.text))

def _compare_testharness_test(self, driver_output, expected_driver_output):

if expected_driver_output.image or expected_driver_output.audio or expected_driver_output.text: