Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: LayoutTests/fast/harness/results.html

Issue 303223008: Overlay expected and actual repaint rects for LayoutTests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add several small features Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/harness/resources/results-test.js ('k') | LayoutTests/fast/harness/results-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/harness/results.html
diff --git a/LayoutTests/fast/harness/results.html b/LayoutTests/fast/harness/results.html
index 3b8d0dab7f4ac5ec90fcf39b60c7ce20c1ce06ae..81d21fe5ebd654ff4ab7c3638b4bbdec0810b63e 100644
--- a/LayoutTests/fast/harness/results.html
+++ b/LayoutTests/fast/harness/results.html
@@ -425,7 +425,7 @@ function shouldUseTracLinks()
return !globalState().results.layout_tests_dir || !location.toString().indexOf('file://') == 0;
}
-function testLink(test)
+function testLinkTarget(test)
{
var target;
if (shouldUseTracLinks()) {
@@ -436,6 +436,12 @@ function testLink(test)
target += '#l1';
} else
target = globalState().results.layout_tests_dir + '/' + test;
+ return target;
+}
+
+function testLink(test)
+{
+ var target = testLinkTarget(test);
return '<a class=test-link href="' + target + '">' + test + '</a><span class=flag onclick="unflag(this)"> \u2691</span>';
}
@@ -522,7 +528,7 @@ function toggleImages()
}
}
-function textResultLinks(prefix)
+function textResultLinks(test, prefix, hasRepaintOverlay)
{
var html = resultLink(prefix, '-expected.txt', 'expected') +
resultLink(prefix, '-actual.txt', 'actual') +
@@ -534,6 +540,9 @@ function textResultLinks(prefix)
if (globalState().results.has_wdiff)
html += resultLink(prefix, '-wdiff.html', 'wdiff');
+ if (hasRepaintOverlay)
+ html += resultLink(prefix, '-overlay.html?' + encodeURIComponent(testLinkTarget(test)), 'overlay');
+
return html;
}
@@ -585,7 +594,7 @@ function tableRow(testObject)
if (testObject.is_testharness_test) {
row += resultLink(testPrefix, '-actual.txt', 'actual');
} else {
- row += textResultLinks(testPrefix);
+ row += textResultLinks(testObject.name, testPrefix, testObject.has_repaint_overlay);
}
}
@@ -700,7 +709,7 @@ function testList(tests, header, tableId)
html += resultLink(stripExtension(test), '-leak-log.txt', 'leak log');
else if (tableId == 'timeout-tests-table') {
// FIXME: only include timeout actual/diff results here if we actually spit out results for timeout tests.
- html += textResultLinks(stripExtension(test));
+ html += textResultLinks(test, stripExtension(test), testObject.has_repaint_overlay);
}
html += '</td></tr></tbody>';
« no previous file with comments | « LayoutTests/fast/harness/resources/results-test.js ('k') | LayoutTests/fast/harness/results-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698