Tools/Scripts/webkitpy/layout_tests/models/test_results.py - Issue 303223008: Overlay expected and actual repaint rects for LayoutTests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/models/test_results.py

Issue 303223008: Overlay expected and actual repaint rects for LayoutTests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add several small features Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py ('k') | Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/models/test_results.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_results.py b/Tools/Scripts/webkitpy/layout_tests/models/test_results.py

index 984f30a37e04a075d8f7538bf7e56b46c4d6929c..2e313cad6199b7314ef50a66b8d31cce2097cf5e 100644

--- a/Tools/Scripts/webkitpy/layout_tests/models/test_results.py

+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_results.py

@@ -38,7 +38,7 @@ class TestResult(object):

def loads(string):

return cPickle.loads(string)

- def __init__(self, test_name, failures=None, test_run_time=None, has_stderr=False, reftest_type=None, pid=None, references=None, device_failed=False):

+ def __init__(self, test_name, failures=None, test_run_time=None, has_stderr=False, reftest_type=None, pid=None, references=None, device_failed=False, has_repaint_overlay=False):

self.test_name = test_name

self.failures = failures or []

self.test_run_time = test_run_time or 0 # The time taken to execute the test itself.

@@ -47,6 +47,7 @@ class TestResult(object):

self.pid = pid

self.references = references or []

self.device_failed = device_failed

+ self.has_repaint_overlay = has_repaint_overlay

# FIXME: Setting this in the constructor makes this class hard to mutate.

self.type = test_failures.determine_result_type(failures)